fix: rfc4716_blob within the complexity limit (quality ratchet) #13

Merged
christianmanivong merged 1 commits from fix/rfc4716-complexity into main 2026-10-31 23:54:06 +00:00
Owner

main's standard job fails since #12: napalm-standard ratchet reports function_complexity: napalm_openmediavault/_local_accounts.py::rfc4716_blob = 11 (new), and the limit is 10. The RFC 4716 body (headers, continuation lines, END line) moves into _rfc4716_body. rfc4716_blob now only tells the two key forms apart. The behaviour is unchanged and the existing parametrised test covers both forms.

Checked locally against device-types and napalm-linux main: 36 tests, ruff, mypy, napalm-standard ratchet ("within the baseline") and check ("meets the standard").

The test failures on main (test_opening_again_puts_the_account_back_into_ssh, NotImplementedError) came from the merge order. #12 went in before NAPALM/napalm-linux#50, and with linux#50 on main that test passes.

main's `standard` job fails since #12: `napalm-standard ratchet` reports `function_complexity: napalm_openmediavault/_local_accounts.py::rfc4716_blob = 11 (new)`, and the limit is 10. The RFC 4716 body (headers, continuation lines, END line) moves into `_rfc4716_body`. `rfc4716_blob` now only tells the two key forms apart. The behaviour is unchanged and the existing parametrised test covers both forms. Checked locally against device-types and napalm-linux `main`: 36 tests, ruff, mypy, `napalm-standard ratchet` ("within the baseline") and `check` ("meets the standard"). The test failures on main (`test_opening_again_puts_the_account_back_into_ssh`, NotImplementedError) came from the merge order. #12 went in before NAPALM/napalm-linux#50, and with linux#50 on main that test passes.
christianmanivong added 1 commit 2026-10-31 23:53:11 +00:00
fix: rfc4716_blob within the complexity limit (quality ratchet)
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m19s
driver / test (3.12) (pull_request) Successful in 1m12s
driver / test (3.13) (pull_request) Successful in 1m9s
driver / lowest (pull_request) Successful in 33s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m30s
CI / driver (pull_request) Successful in 3m16s
driver / publish (pull_request) Skipped
a88e02ea56
The RFC 4716 body moves into _rfc4716_body; rfc4716_blob only tells the
two key forms apart. main's ratchet job failed on complexity 11.
christianmanivong merged commit 57feb44a76 into main 2026-10-31 23:54:06 +00:00
christianmanivong deleted branch fix/rfc4716-complexity 2026-10-31 23:54:06 +00:00
Sign in to join this conversation.