set_hostname() the way OMV's web UI renames the NAS, instead of the napalm-linux rename it inherits since NAPALM/napalm-linux#45 (OMV regenerates /etc/hostname and /etc/hosts from conf.system.network.dns, so that one would not last).
Network.setGeneralSettings — an FQDN sets the domain too, a bare name keeps it
Config.applyChanges with an explicit module list: the modules the rename made dirty, plus the hostname modules (hostname, hosts, postfix, avahi, samba, proftpd, systemdnetworkd) that already were. Other pending web-UI changes stay pending — on netOrk's test NAS apt and rsyslog were pending at the time.
RFC 1123 validation before anything runs
Checked read-only against OMV 8.6.0 on a real NAS (getGeneralSettings, the RPC sources of setGeneralSettings/applyChanges, the modules listening to conf.system.network.dns). Not renamed live, on purpose.
Tests: 21 passed, also against napalm-linux 0.15.0 (the floor); ruff, mypy, ratchet, napalm-standard check green locally. netOrk side: NetOrk/netork#1671.
`set_hostname()` the way OMV's web UI renames the NAS, instead of the napalm-linux rename it inherits since NAPALM/napalm-linux#45 (OMV regenerates `/etc/hostname` and `/etc/hosts` from `conf.system.network.dns`, so that one would not last).
- `Network.setGeneralSettings` — an FQDN sets the domain too, a bare name keeps it
- `Config.applyChanges` with an explicit module list: the modules the rename made dirty, plus the hostname modules (`hostname`, `hosts`, `postfix`, `avahi`, `samba`, `proftpd`, `systemdnetworkd`) that already were. Other pending web-UI changes stay pending — on netOrk's test NAS `apt` and `rsyslog` were pending at the time.
- RFC 1123 validation before anything runs
Checked read-only against OMV 8.6.0 on a real NAS (`getGeneralSettings`, the RPC sources of `setGeneralSettings`/`applyChanges`, the modules listening to `conf.system.network.dns`). Not renamed live, on purpose.
Tests: 21 passed, also against napalm-linux 0.15.0 (the floor); ruff, mypy, ratchet, `napalm-standard check` green locally. netOrk side: NetOrk/netork#1671.
napalm-linux now renames a host through hostnamectl, /etc/hostname and
/etc/hosts (NAPALM/napalm-linux#45). OMV regenerates those files from
conf.system.network.dns on its next apply, so the inherited rename would
not last.
set_hostname() goes where OMV's web UI goes: Network.setGeneralSettings
(an FQDN sets the domain too, a bare name keeps it), then
Config.applyChanges with an explicit module list -- the modules the
rename made dirty, plus the hostname modules that already were. Changes
someone left pending in the web UI stay pending. Checked against the RPC
sources of OMV 8.6 (rpc/network.inc, rpc/config.inc).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
set_hostname()the way OMV's web UI renames the NAS, instead of the napalm-linux rename it inherits since NAPALM/napalm-linux#45 (OMV regenerates/etc/hostnameand/etc/hostsfromconf.system.network.dns, so that one would not last).Network.setGeneralSettings— an FQDN sets the domain too, a bare name keeps itConfig.applyChangeswith an explicit module list: the modules the rename made dirty, plus the hostname modules (hostname,hosts,postfix,avahi,samba,proftpd,systemdnetworkd) that already were. Other pending web-UI changes stay pending — on netOrk's test NASaptandrsyslogwere pending at the time.Checked read-only against OMV 8.6.0 on a real NAS (
getGeneralSettings, the RPC sources ofsetGeneralSettings/applyChanges, the modules listening toconf.system.network.dns). Not renamed live, on purpose.Tests: 21 passed, also against napalm-linux 0.15.0 (the floor); ruff, mypy, ratchet,
napalm-standard checkgreen locally. netOrk side: NetOrk/netork#1671.