fix: Plus stubs, Plus ping, Smart optional_args and message (#9, #5, #7) #18

Merged
christianmanivong merged 3 commits from fix/bugs-2026-11 into main 2026-11-01 22:00:32 +00:00
Owner

Three bug fixes, one commit each.

  • fix(plus)!: the Plus driver's set_vlan, delete_vlan and set_interface existed only to raise NotImplementedError; they are removed, so callers that check callable(getattr(…)) read them as unsupported (#9). Breaking (public methods removed) → the next release bumps MINOR.
  • fix(plus): the Plus ping override that only raised is removed; NAPALM's stub is inherited and supports_ping() is False, so ping sweeps skip Plus switches instead of reporting every host as an error (#5).
  • fix(smart): the Smart driver works on a copy of the caller's optional_args, its connection error is English, and the stale requirements.txt (older floors) is removed (#7). The dependency and URL points of #7 were already fixed on main (34554ea, 10a3b1e).

Tested: fixtures only. pytest 110 passed, ruff, mypy, napalm-standard check/ratchet green.

Closes #9
Closes #5
Closes #7

Three bug fixes, one commit each. - `fix(plus)!`: the Plus driver's `set_vlan`, `delete_vlan` and `set_interface` existed only to raise `NotImplementedError`; they are removed, so callers that check `callable(getattr(…))` read them as unsupported (#9). **Breaking** (public methods removed) → the next release bumps MINOR. - `fix(plus)`: the Plus `ping` override that only raised is removed; NAPALM's stub is inherited and `supports_ping()` is False, so ping sweeps skip Plus switches instead of reporting every host as an error (#5). - `fix(smart)`: the Smart driver works on a copy of the caller's `optional_args`, its connection error is English, and the stale `requirements.txt` (older floors) is removed (#7). The dependency and URL points of #7 were already fixed on main (34554ea, 10a3b1e). Tested: fixtures only. pytest 110 passed, ruff, mypy, `napalm-standard check`/`ratchet` green. Closes #9 Closes #5 Closes #7
christianmanivong added 3 commits 2026-11-01 20:57:15 +00:00
The three methods only raised NotImplementedError. napalm-device-types
declares them on SwitchDriver for type checking only, so a driver that
cannot carry them out is meant not to have them; netOrk reads the
capability from the method being callable and offered "Add VLAN" and the
port VLAN editor on Plus switches, which then failed.

BREAKING CHANGE: NetgearPlusDriver has no set_vlan, delete_vlan or
set_interface attribute any more.

Closes #9
The Plus driver overrode ping only to raise NotImplementedError. An
override is what napalm-device-types' driver_supports_ping looks for, so
the driver was offered as a ping-sweep source and every target came back
as an error. Without the override it inherits NAPALM's stub, which
raises the same way and reads as unsupported.

Closes #5
fix(smart): copy optional_args, report in English, drop requirements
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 12s
driver / types (pull_request) Successful in 1m0s
driver / test (3.12) (pull_request) Successful in 54s
driver / test (3.13) (pull_request) Successful in 51s
driver / lowest (pull_request) Successful in 27s
driver / build (pull_request) Successful in 25s
driver / security (pull_request) Successful in 1m2s
CI / driver (pull_request) Successful in 2m23s
driver / publish (pull_request) Skipped
09092be5db
The Smart driver's constructor wrote its connection defaults into the
optional_args dict the caller passed in, and an unexpected connect error
started with a German phrase. requirements.txt repeated pyproject's
dependencies with floors older than the driver needs.

The issue's other points were already fixed on main: pyproject declares
napalm-device-types since 34554ea and points its URLs at git.netork.io
since 10a3b1e.

Closes #7
christianmanivong merged commit 4b89a3d767 into main 2026-11-01 22:00:32 +00:00
christianmanivong deleted branch fix/bugs-2026-11 2026-11-01 22:00:32 +00:00
Sign in to join this conversation.