fix(plus)!: the Plus driver's set_vlan, delete_vlan and set_interface existed only to raise NotImplementedError; they are removed, so callers that check callable(getattr(…)) read them as unsupported (#9). Breaking (public methods removed) → the next release bumps MINOR.
fix(plus): the Plus ping override that only raised is removed; NAPALM's stub is inherited and supports_ping() is False, so ping sweeps skip Plus switches instead of reporting every host as an error (#5).
fix(smart): the Smart driver works on a copy of the caller's optional_args, its connection error is English, and the stale requirements.txt (older floors) is removed (#7). The dependency and URL points of #7 were already fixed on main (34554ea, 10a3b1e).
Three bug fixes, one commit each.
- `fix(plus)!`: the Plus driver's `set_vlan`, `delete_vlan` and `set_interface` existed only to raise `NotImplementedError`; they are removed, so callers that check `callable(getattr(…))` read them as unsupported (#9). **Breaking** (public methods removed) → the next release bumps MINOR.
- `fix(plus)`: the Plus `ping` override that only raised is removed; NAPALM's stub is inherited and `supports_ping()` is False, so ping sweeps skip Plus switches instead of reporting every host as an error (#5).
- `fix(smart)`: the Smart driver works on a copy of the caller's `optional_args`, its connection error is English, and the stale `requirements.txt` (older floors) is removed (#7). The dependency and URL points of #7 were already fixed on main (34554ea, 10a3b1e).
Tested: fixtures only. pytest 110 passed, ruff, mypy, `napalm-standard check`/`ratchet` green.
Closes #9
Closes #5
Closes #7
The three methods only raised NotImplementedError. napalm-device-types
declares them on SwitchDriver for type checking only, so a driver that
cannot carry them out is meant not to have them; netOrk reads the
capability from the method being callable and offered "Add VLAN" and the
port VLAN editor on Plus switches, which then failed.
BREAKING CHANGE: NetgearPlusDriver has no set_vlan, delete_vlan or
set_interface attribute any more.
Closes#9
The Plus driver overrode ping only to raise NotImplementedError. An
override is what napalm-device-types' driver_supports_ping looks for, so
the driver was offered as a ping-sweep source and every target came back
as an error. Without the override it inherits NAPALM's stub, which
raises the same way and reads as unsupported.
Closes#5
The Smart driver's constructor wrote its connection defaults into the
optional_args dict the caller passed in, and an unexpected connect error
started with a German phrase. requirements.txt repeated pyproject's
dependencies with floors older than the driver needs.
The issue's other points were already fixed on main: pyproject declares
napalm-device-types since 34554ea and points its URLs at git.netork.io
since 10a3b1e.
Closes#7
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Three bug fixes, one commit each.
fix(plus)!: the Plus driver'sset_vlan,delete_vlanandset_interfaceexisted only to raiseNotImplementedError; they are removed, so callers that checkcallable(getattr(…))read them as unsupported (#9). Breaking (public methods removed) → the next release bumps MINOR.fix(plus): the Pluspingoverride that only raised is removed; NAPALM's stub is inherited andsupports_ping()is False, so ping sweeps skip Plus switches instead of reporting every host as an error (#5).fix(smart): the Smart driver works on a copy of the caller'soptional_args, its connection error is English, and the stalerequirements.txt(older floors) is removed (#7). The dependency and URL points of #7 were already fixed on main (34554ea,10a3b1e).Tested: fixtures only. pytest 110 passed, ruff, mypy,
napalm-standard check/ratchetgreen.Closes #9
Closes #5
Closes #7