netgear_plus: set_vlan and set_interface exist only to raise NotImplementedError #9

Closed
opened 2026-10-15 12:50:31 +00:00 by christianmanivong · 0 comments
Owner

NetgearPlusDriver.set_vlan (napalm_netgear/netgear_plus.py:510) and set_interface (:740) are defined but always raise NotImplementedError ("not supported via HTTP").

napalm-device-types declares both on SwitchDriver only under TYPE_CHECKING, so a driver that cannot do it is meant to not have the method. netOrk detects the ability with callable(getattr(driver, "set_vlan")) (driver_creates_vlans / driver_sets_port_vlans, netork#1118). With the stubs in place it offers Add VLAN and the interface editor on Netgear Plus switches, and the run then ends with the NotImplementedError text.

Fix: delete both stubs (and check delete_vlan, which sits right after set_vlan), then bump the pin in netOrk's vendor-drivers.txt.

Prio: P3 (the action fails with a clear message rather than doing harm; the button just should not be there).

`NetgearPlusDriver.set_vlan` (`napalm_netgear/netgear_plus.py:510`) and `set_interface` (`:740`) are defined but always raise `NotImplementedError` ("not supported via HTTP"). napalm-device-types declares both on `SwitchDriver` only under `TYPE_CHECKING`, so a driver that cannot do it is meant to *not have* the method. netOrk detects the ability with `callable(getattr(driver, "set_vlan"))` (`driver_creates_vlans` / `driver_sets_port_vlans`, netork#1118). With the stubs in place it offers **Add VLAN** and the interface editor on Netgear Plus switches, and the run then ends with the NotImplementedError text. **Fix:** delete both stubs (and check `delete_vlan`, which sits right after `set_vlan`), then bump the pin in netOrk's `vendor-drivers.txt`. Prio: P3 (the action fails with a clear message rather than doing harm; the button just should not be there).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-netgear#9