Without a root login and without a sudo password, _run_privileged typed "sudo -n <command>" into the interactive shell. sudo covered only the first simple command of the line, and dnf's and yum's advisory query, which starts with a brace group, did not parse at all: no status marker ever arrived, so netmiko waited out the 120 s read timeout and get_available_updates() failed. This is the default path for netOrk's own NOPASSWD account. The command now goes to "sudo -n sh -c" as one argument, as _as_root already does with a password. A status echo at its end stays outside sh -c: it reports sh's status, which is the command's, and still arrives when sudo refuses. Closes #56
98 lines
4.1 KiB
Python
98 lines
4.1 KiB
Python
"""The interactive shell netmiko opens, made fit to be read before the first command."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import re
|
|
from shlex import quote
|
|
from typing import Any
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
#: The end of a command's output when nothing better is known: a line that looks
|
|
#: like a shell prompt.
|
|
PROMPT_RE = r"[#$\>]\s*$"
|
|
|
|
#: A command ending in ``echo __NAME=$?`` reports its exit status on a line of its
|
|
#: own: the driver's ``_RC_MARKER``, ``__APT_RC=`` and ``__SVC_RC=`` in
|
|
#: napalm-device-types.
|
|
STATUS_ECHO_RE = re.compile(r"echo\s+(__[A-Z_]+=)\$\?")
|
|
|
|
#: The same echo as the last command of a line: ``sudo_without_password`` keeps it
|
|
#: outside sudo.
|
|
_TRAILING_STATUS_ECHO_RE = re.compile(r";\s*echo\s+__[A-Z_]+=\$\?\s*$")
|
|
|
|
|
|
def expect_for(command: str) -> str:
|
|
"""The pattern that ends *command*'s output.
|
|
|
|
netmiko stops reading as soon as the pattern matches what it has read so far.
|
|
A line the command prints can end in ``#``, ``$`` or ``>`` -- apt's
|
|
``<ftpmaster@ubuntu.com>`` after a bad signature -- and was taken for the
|
|
prompt: half the output came back, and the rest started the next command's
|
|
(#615). A command that echoes its exit status is read until that marker, with
|
|
a number, and the prompt line after it. The echoed command line carries a
|
|
literal ``$?`` and cannot match.
|
|
"""
|
|
markers: list[str] = STATUS_ECHO_RE.findall(command)
|
|
if not markers:
|
|
return PROMPT_RE
|
|
return re.escape(markers[-1]) + r"\d+\s*\n.*" + PROMPT_RE
|
|
|
|
|
|
def sudo_without_password(command: str) -> str:
|
|
"""The line that runs all of *command* as root through ``sudo -n`` (#56).
|
|
|
|
The command goes to ``sh -c`` as one argument: ``sudo -n <command>`` covered only
|
|
its first simple command, and one that starts with a brace group did not parse.
|
|
A status echo at its end stays outside and reports sh's status, the command's:
|
|
it arrives when sudo refuses as well, where netmiko would otherwise wait for it
|
|
until the read timeout.
|
|
"""
|
|
echo = _TRAILING_STATUS_ECHO_RE.search(command)
|
|
body, tail = (command[: echo.start()], echo.group()) if echo else (command, "")
|
|
return f"sudo -n sh -c {quote(body)}{tail}"
|
|
|
|
|
|
#: Sent before anything else in the interactive session (NetOrk/netork#1039):
|
|
#: the shell writes no history file and records nothing more. The leading space
|
|
#: keeps this line itself out of a history under ``HISTCONTROL=ignorespace``;
|
|
#: a shell without ``set -o history`` (dash) only complains, to /dev/null.
|
|
HISTORY_OFF = " unset HISTFILE; set +o history 2>/dev/null; true"
|
|
|
|
#: Sent right after ``HISTORY_OFF`` (#41): systemd 258's
|
|
#: ``/etc/profile.d/80-systemd-osc-context.sh`` wraps every command in OSC 3008
|
|
#: sequences from ``PS0`` and ``PROMPT_COMMAND``, each with a fresh UUID. It appends
|
|
#: to ``PROMPT_COMMAND`` as an array, so only ``unset`` removes its hook.
|
|
PROMPT_HOOKS_OFF = " unset PS0 PROMPT_COMMAND; true"
|
|
|
|
#: Keeps the PTY from wrapping long output lines (e.g. docker JSON).
|
|
NO_LINE_WRAP = "stty cols 10000 2>/dev/null || true"
|
|
|
|
|
|
def prepare_shell(device: Any, hostname: str) -> None:
|
|
"""Make netmiko's fresh shell *device* fit to read, one step at a time.
|
|
|
|
A step the shell refuses is logged and skipped: none of them is worth
|
|
failing the connection for.
|
|
"""
|
|
# No history before anything else is typed (NetOrk/netork#1039).
|
|
try:
|
|
device.send_command(HISTORY_OFF, expect_string=PROMPT_RE)
|
|
except Exception:
|
|
logger.debug("Could not switch the shell history off on %s", hostname, exc_info=True)
|
|
|
|
# No systemd OSC 3008 context around every command (#41). netmiko learned
|
|
# the prompt with those sequences in front, and a prompt carrying a fresh
|
|
# UUID never matches again, so it reads the prompt anew once they are gone.
|
|
try:
|
|
device.send_command(PROMPT_HOOKS_OFF, expect_string=PROMPT_RE)
|
|
device.set_base_prompt()
|
|
except Exception:
|
|
logger.debug("Could not switch the prompt hooks off on %s", hostname, exc_info=True)
|
|
|
|
try:
|
|
device.send_command(NO_LINE_WRAP, expect_string=PROMPT_RE)
|
|
except Exception:
|
|
logger.debug("%s: ignored", hostname, exc_info=True)
|