fix(driver): load_replace_candidate is None, not a stub that raises (NetOrk/netork#2503) #81

Merged
christianmanivong merged 2 commits from fix/no-config-replace into main 2026-11-13 21:39:04 +00:00
2 Commits
Author SHA1 Message Date
Christian Manivong de91b1a918 style: one comment line, so linux.py keeps its recorded length
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 12s
driver / types (pull_request) Successful in 55s
driver / test (3.12) (pull_request) Successful in 55s
driver / test (3.13) (pull_request) Successful in 50s
driver / lowest (pull_request) Successful in 27s
driver / build (pull_request) Successful in 27s
driver / security (pull_request) Successful in 56s
CI / driver (pull_request) Successful in 2m18s
driver / publish (pull_request) Skipped
2026-11-13 21:50:25 +01:00
Christian Manivong c9a9d532aa fix(driver): load_replace_candidate is None, not a stub that raises (NetOrk/netork#2503)
driver / lint (pull_request) Successful in 19s
driver / standard (pull_request) Failing after 27s
driver / types (pull_request) Successful in 3m34s
driver / test (3.13) (pull_request) Successful in 3m12s
driver / test (3.12) (pull_request) Successful in 3m23s
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Failing after 4m54s
driver / publish (pull_request) Skipped
The driver cannot replace a device's configuration, and said so with a
load_replace_candidate that raised NotImplementedError. A method that only
raises still looks like a replace to anyone who asks whether the driver has
one: netOrk offered a config restore for these devices that could only fail.

None is how a driver switches off a method, the convention netOrk's
capability checks and napalm-device-types follow, so asking now says no.
Nothing in the driver calls it.
2026-11-13 21:45:23 +01:00