tests: test_time_sync expects no dhcp_ntp_servers with device-types 4.36 #78

Closed
opened 2026-11-12 11:14:31 +00:00 by christianmanivong · 1 comment
Owner

Priority: P3 (red test on main, no wrong behaviour on hosts)

tests/test_time_sync.py::test_the_reading_is_one_round_trip_as_the_login_user fails on main (235c1e9) against napalm-device-types 4.36.2 (a8fedf2): get_time_sync() now also returns 'dhcp_ntp_servers': [], which the expected dict does not list. It probably came with the DHCP NTP servers in device-types (NetOrk/netork#2380). The test's expectation needs the key.

Priority: P3 (red test on main, no wrong behaviour on hosts) `tests/test_time_sync.py::test_the_reading_is_one_round_trip_as_the_login_user` fails on main (235c1e9) against napalm-device-types 4.36.2 (a8fedf2): `get_time_sync()` now also returns `'dhcp_ntp_servers': []`, which the expected dict does not list. It probably came with the DHCP NTP servers in device-types (NetOrk/netork#2380). The test's expectation needs the key.
Author
Owner

Already fixed on main by 1d377ac (test(time-sync): the reading carries dhcp_ntp_servers since device-types 4.36, #75).

Already fixed on main by 1d377ac (test(time-sync): the reading carries dhcp_ntp_servers since device-types 4.36, #75).
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-linux#78