fix(interfaces): the WAN interface speed is reported in Mbit/s (NewLayer1DownstreamMaxBitRate is bit/s; it was divided by 1000, giving kbit/s) (#2). get_wan_status's max_bitrate_* stay in kbit/s, as device-types defines them.
fix(system): timezone comes from NewLocalTimeZoneName, not the current local time (part of #3).
docs(system): firmware_version keeps its name and is documented as the version on offer (empty when none; the running version is get_facts()["os_version"]), in the docstring and a new README section (rest of #3).
Tested: fixtures only, run with no network (unshare -rn) — the suite otherwise opens a real socket through NAPALM's __del__ → is_alive() (separate test fix). pytest 74 passed, ruff, mypy, napalm-standard check/ratchet green.
Two bug fixes, one commit each.
- `fix(interfaces)`: the WAN interface speed is reported in Mbit/s (`NewLayer1DownstreamMaxBitRate` is bit/s; it was divided by 1000, giving kbit/s) (#2). `get_wan_status`'s `max_bitrate_*` stay in kbit/s, as device-types defines them.
- `fix(system)`: `timezone` comes from `NewLocalTimeZoneName`, not the current local time (part of #3).
- `docs(system)`: `firmware_version` keeps its name and is documented as the version *on offer* (empty when none; the running version is `get_facts()["os_version"]`), in the docstring and a new README section (rest of #3).
Tested: fixtures only, run with no network (`unshare -rn`) — the suite otherwise opens a real socket through NAPALM's `__del__` → `is_alive()` (separate test fix). pytest 74 passed, ruff, mypy, `napalm-standard check`/`ratchet` green.
Closes #2
Closes #3
NewLayer1DownstreamMaxBitRate is bit/s; dividing by 1000 gave kbit/s,
so a 250 Mbit/s line came out as 250000 in a field NAPALM defines as
Mbit/s.
Closes#2
Time1.GetInfo's NewCurrentLocalTime is the box's clock, so `timezone`
held a timestamp that changed on every poll. NewLocalTimeZoneName is
the zone the box is set to.
The other half of the issue, firmware_version being the version on
offer, stays open: the field is documented and consumed that way.
Refs #3
get_system_config()'s firmware_version reads NewX_AVM-DE_Version, the
firmware the box offers as an update, empty when it offers none, not the
version running (get_facts()["os_version"]). The name stays; the README
and the docstring now say what it holds, and that a box answering only
UserInterface1.GetInfo reports firmware_update_available without it.
No behaviour change.
Closes#3
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Two bug fixes, one commit each.
fix(interfaces): the WAN interface speed is reported in Mbit/s (NewLayer1DownstreamMaxBitRateis bit/s; it was divided by 1000, giving kbit/s) (#2).get_wan_status'smax_bitrate_*stay in kbit/s, as device-types defines them.fix(system):timezonecomes fromNewLocalTimeZoneName, not the current local time (part of #3).docs(system):firmware_versionkeeps its name and is documented as the version on offer (empty when none; the running version isget_facts()["os_version"]), in the docstring and a new README section (rest of #3).Tested: fixtures only, run with no network (
unshare -rn) — the suite otherwise opens a real socket through NAPALM's__del__→is_alive()(separate test fix). pytest 74 passed, ruff, mypy,napalm-standard check/ratchetgreen.Closes #2
Closes #3