NAPALM/napalm-device-types
1
0 Fork 0
Code Issues 12 Pull Requests 1 Actions Packages Projects Releases 2 Wiki Activity

feat: fix routines as templates with the caller's values; deprecate run_device_action (4.13.0) #41

Merged
christianmanivong merged 1 commits from feat/fix-templates-33 into main 2026-10-16 22:43:23 +00:00
Conversation 0 Commits 1 Files Changed 8
+398 -2
1 Commits
Author SHA1 Message Date
christianmanivong 9324a5b8f1 feat: fix routines as templates with the caller's values; deprecate run_device_action (4.13.0)
CI / test (3.10) (push) Successful in 34s
Details
CI / test (3.11) (push) Successful in 31s
Details
CI / test (3.12) (push) Successful in 31s
Details
CI / test (3.13) (push) Successful in 27s
Details
CI / test (3.10) (pull_request) Successful in 27s
Details
CI / test (3.11) (pull_request) Successful in 28s
Details
CI / test (3.12) (pull_request) Successful in 28s
Details
CI / test (3.13) (pull_request) Successful in 27s
Details 
run_device_action was a string dispatch drivers filled with an
application's remediations, values hard-coded inside (community
"public", the caller's address, a /24 firewall rule).

napalm_device_types.fixes declares them as templates instead. A
template runs declared steps in order and stops at the first failure
(run_fix_steps); the driver implements the steps, or overrides the
whole method where its device takes the change in one call; every
value comes from the caller.

- SnmpAgentMixin.configure_snmp_agent(settings): install, configure,
  firewall, start. The caller verifies with its own SNMP client.
  get_management_peer() (optional) says the address the device sees the
  management connection come from, for choosing allowed_sources.
- EnsurePackageMixin.ensure_package(name): install only what is missing.
- PackageProxyMixin.configure_package_proxy(url): declared.
- ContainerEngineMixin.grant_container_engine_access(user): declared.

None is mixed into a role base, so a capability check stays truthful.

Closes #33
 2026-10-16 15:29:42 +02:00