feat(system-identity): read the system firmware with the identity #119

Merged
christianmanivong merged 2 commits from feat/system-firmware into main 2026-11-13 22:11:26 +00:00
Owner

get_system_identity() also reads the host's system firmware (BIOS or UEFI) from /sys/class/dmi/id, in the same round trip as the SMBIOS identity: bios_vendor, bios_version, bios_date (ISO 8601).

  • Only the vendors' text defaults (To be filled by O.E.M., Default string) are placeholders for the firmware; a version of 1 is a version.
  • A date that is no MM/DD/YYYY reads as empty.
  • Output of the three identity fields alone still parses, with the firmware empty.

The exact-dict tests of napalm-linux and napalm-proxmox are made key-wise in their own PRs (chore/identity-test-keys), so their CI stays green once this is on main.

For NetOrk/netork#2518.

`get_system_identity()` also reads the host's system firmware (BIOS or UEFI) from `/sys/class/dmi/id`, in the same round trip as the SMBIOS identity: `bios_vendor`, `bios_version`, `bios_date` (ISO 8601). - Only the vendors' text defaults (`To be filled by O.E.M.`, `Default string`) are placeholders for the firmware; a version of `1` is a version. - A date that is no `MM/DD/YYYY` reads as empty. - Output of the three identity fields alone still parses, with the firmware empty. The exact-dict tests of napalm-linux and napalm-proxmox are made key-wise in their own PRs (`chore/identity-test-keys`), so their CI stays green once this is on main. For NetOrk/netork#2518.
christianmanivong added 1 commit 2026-11-13 22:00:41 +00:00
feat(system-identity): read the system firmware with the identity
driver / lint (pull_request) Successful in 13s
driver / standard (pull_request) Failing after 15s
driver / types (pull_request) Successful in 52s
driver / test (3.13) (pull_request) Successful in 1m3s
driver / test (3.12) (pull_request) Successful in 1m11s
driver / lowest (pull_request) Successful in 39s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Failing after 2m17s
driver / publish (pull_request) Skipped
9ecc6823c8
get_system_identity() also reads bios_vendor, bios_version and bios_date
from /sys/class/dmi/id, in the same round trip as the SMBIOS identity.
The date is given as ISO 8601; anything that is no MM/DD/YYYY reads as
empty. Only the vendors' text defaults are placeholders for the firmware:
a version of "1" is a version, unlike a serial of one repeated character.

Output of the three identity fields alone still parses, with the firmware
empty.

NetOrk/netork#2518
christianmanivong added 1 commit 2026-11-13 22:04:19 +00:00
refactor(system-identity): keep SystemIdentityDict with its mixin
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Successful in 57s
driver / test (3.13) (pull_request) Successful in 1m6s
driver / test (3.12) (pull_request) Successful in 1m15s
driver / lowest (pull_request) Successful in 38s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m4s
CI / driver (pull_request) Successful in 2m51s
driver / publish (pull_request) Skipped
c25f39768f
models.py is over its line limit and may not grow; the dict has no other
user than system_identity.py, as clusters.py and apt_proxy.py keep theirs.

NetOrk/netork#2518
christianmanivong merged commit 74d2f42b0e into main 2026-11-13 22:11:26 +00:00
christianmanivong deleted branch feat/system-firmware 2026-11-13 22:11:26 +00:00
Sign in to join this conversation.