Found while fixing #106 (PR #112). apply_dhcp_subnetset (napalm_device_types/dhcp.py) calls apply_dhcp_subnet for every add and update and commits only at the end. One refused write raises out of the generator before commit_dhcp_subnets(): the subnets written before it stay saved but inactive, and because the device then reports them as configured, the next diff is empty and nothing ever commits them.
This is the hazard apply_dhcp_reservationset was fixed for in 4.35.1 (#104): a [failed] line per refused write, the others written, any non-empty diff committed, then DhcpApplyError. The subnet apply should behave the same way.
Priority: P3 (important, not urgent).
Found while fixing #106 (PR #112). `apply_dhcp_subnetset` (`napalm_device_types/dhcp.py`) calls `apply_dhcp_subnet` for every add and update and commits only at the end. One refused write raises out of the generator before `commit_dhcp_subnets()`: the subnets written before it stay saved but inactive, and because the device then reports them as configured, the next diff is empty and nothing ever commits them.
This is the hazard `apply_dhcp_reservationset` was fixed for in 4.35.1 (#104): a `[failed]` line per refused write, the others written, any non-empty diff committed, then `DhcpApplyError`. The subnet apply should behave the same way.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Priority: P3 (important, not urgent).
Found while fixing #106 (PR #112).
apply_dhcp_subnetset(napalm_device_types/dhcp.py) callsapply_dhcp_subnetfor every add and update and commits only at the end. One refused write raises out of the generator beforecommit_dhcp_subnets(): the subnets written before it stay saved but inactive, and because the device then reports them as configured, the next diff is empty and nothing ever commits them.This is the hazard
apply_dhcp_reservationsetwas fixed for in 4.35.1 (#104): a[failed]line per refused write, the others written, any non-empty diff committed, thenDhcpApplyError. The subnet apply should behave the same way.