apply_dhcp_reservationset committed only after the last write, so one write the device refused (OPNsense: an address in a subnet Kea does not manage) ended the run before the commit. Later reservations went unwritten; earlier ones stayed saved but inactive, and the next diff found them configured and never committed them.
A refused change gets a [failed] <mac> -> <ip>: <reason> line; the others are still written.
Any non-empty diff commits, also one whose every write was refused, so writes an interrupted run saved take effect.
DhcpApplyError (a RuntimeError, exported) is raised after the commit with how many of how many were refused.
4.35.1. Tests: TestApplyWithARefusedReservation; full suite, ruff and mypy green.
`apply_dhcp_reservationset` committed only after the last write, so one write the device refused (OPNsense: an address in a subnet Kea does not manage) ended the run before the commit. Later reservations went unwritten; earlier ones stayed saved but inactive, and the next diff found them configured and never committed them.
- A refused change gets a `[failed] <mac> -> <ip>: <reason>` line; the others are still written.
- Any non-empty diff commits, also one whose every write was refused, so writes an interrupted run saved take effect.
- `DhcpApplyError` (a `RuntimeError`, exported) is raised after the commit with how many of how many were refused.
4.35.1. Tests: `TestApplyWithARefusedReservation`; full suite, ruff and mypy green.
Refs NetOrk/netork#2381
apply_dhcp_reservationset wrote the diff one reservation at a time and
committed only after the last. A write the device refused -- on
OPNsense, an address in a subnet Kea does not manage -- ended the run
before the commit: every later reservation went unwritten, and the
earlier ones stayed saved but inactive. The next diff read those back as
configured, reported no changes and never committed them.
A refused change now gets a "[failed] <mac> -> <ip>: <reason>" line and
the others are still written. Any non-empty diff commits, also one whose
every write was refused, so writes an interrupted earlier run saved take
effect. DhcpApplyError (a RuntimeError, exported) is raised after the
commit with how many of how many changes were refused.
Refs NetOrk/netork#2381
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
apply_dhcp_reservationsetcommitted only after the last write, so one write the device refused (OPNsense: an address in a subnet Kea does not manage) ended the run before the commit. Later reservations went unwritten; earlier ones stayed saved but inactive, and the next diff found them configured and never committed them.[failed] <mac> -> <ip>: <reason>line; the others are still written.DhcpApplyError(aRuntimeError, exported) is raised after the commit with how many of how many were refused.4.35.1. Tests:
TestApplyWithARefusedReservation; full suite, ruff and mypy green.Refs NetOrk/netork#2381