NAPALM/napalm-linux
1
0 Fork 0
Code Issues 12 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat: report the configured package proxy, not apt_proxy_missing (0.9.0) #32

Merged
christianmanivong merged 1 commits from feat/facts-not-warnings into master 2026-10-17 08:34:55 +00:00
Conversation 0 Commits 1 Files Changed 5
+39 -37
christianmanivong commented 2026-10-17 07:33:20 +00:00
Owner
Copy link
Copy source

Adds get_package_proxy() (napalm-device-types 4.14 PackageProxyMixin): the proxy in the apt configuration netOrk writes, or None. Drops get_device_warnings and _apt_proxy_url; netOrk compares the proxy with the one it wants and names apt_proxy_missing itself (NetOrk/netork#1146, NetOrk/netork#1111).

Requires napalm-device-types >= 4.14.0.

Closes #28

Adds `get_package_proxy()` (napalm-device-types 4.14 `PackageProxyMixin`): the proxy in the apt configuration netOrk writes, or None. Drops `get_device_warnings` and `_apt_proxy_url`; netOrk compares the proxy with the one it wants and names `apt_proxy_missing` itself (NetOrk/netork#1146, NetOrk/netork#1111). Requires napalm-device-types >= 4.14.0. Closes #28
christianmanivong added 1 commit 2026-10-17 07:33:20 +00:00
feat!: report the package proxy as a fact; no warnings of its own (0.9.0)
CI / test (3.10) (push) Successful in 34s
Details
CI / test (3.11) (push) Successful in 32s
Details
CI / test (3.12) (push) Successful in 29s
Details
CI / test (3.10) (pull_request) Successful in 25s
Details
CI / test (3.11) (pull_request) Successful in 23s
Details
CI / test (3.12) (pull_request) Successful in 25s
Details
decd64b876 
get_device_warnings decided two things for the application: that any
pending update is a warning (it re-read the updates for that), and
whether apt's proxy is the one the application's setting wants, which
it was handed as optional_args["apt_proxy_url"].

The driver reports facts instead (napalm-device-types 4.14):
get_package_proxy() says which proxy apt fetches through, None for none
or on a non-apt host; the updates are get_available_updates() as
before. get_device_warnings and the apt_proxy_url argument go.

BREAKING CHANGE: get_device_warnings and optional_args["apt_proxy_url"]
are removed. Requires napalm-device-types 4.14.

Closes #28
christianmanivong merged commit c8e2b328d7 into master 2026-10-17 08:34:55 +00:00
christianmanivong deleted branch feat/facts-not-warnings 2026-10-17 08:34:55 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-linux#32