feat: NetworkTargetDict.uplinks, the NICs a bridge leaves through (NetOrk/netork#1325) #58

Merged
christianmanivong merged 2 commits from feat/network-target-uplinks into main 2026-10-30 09:54:19 +00:00
Owner

Summary

A network target can name the physical NICs it leaves the host through, so netOrk can follow them to the switch port behind a bridge (NetOrk/netork#1325). A VM on a VLAN-aware bridge without a VLAN tag lands in whatever that port carries untagged; netOrk's VM dialog warns when that is nothing, or a VLAN it knows no DHCP for.

Changes

  • NetworkTargetDict.uplinks: NotRequired[list[list[str]]]: one group per way out of the bridge, a bond's slaves together ([["eno1", "eno2"]]), a single NIC alone ([["eno1"]]). Internal, VLAN and virtual ports are no uplinks. A missing key means the driver cannot tell; [] is a bridge without uplink.
  • Grouped because a bond is one link: lldpd often reports a neighbour on one slave only, and the caller may let that one speak for the bond. Flat, a bond and two separate NICs looked the same.
  • get_network_targets docstring, README hypervisor example, CHANGELOG under Unreleased.
  • The models.py docstring was tightened so the file stays at its ratchet cap (1504 lines).

Tests

  • tests/test_network_target_uplinks.py: the key is optional and typed list[list[str]]; the core keys stay required.
  • pytest 863 passed; ruff, ruff format, mypy clean; napalm-standard check meets the standard, ratchet within the baseline.

Implemented by napalm-proxmox (PR follows). Priority: P4.

## Summary A network target can name the physical NICs it leaves the host through, so netOrk can follow them to the switch port behind a bridge (NetOrk/netork#1325). A VM on a VLAN-aware bridge without a VLAN tag lands in whatever that port carries untagged; netOrk's VM dialog warns when that is nothing, or a VLAN it knows no DHCP for. ## Changes - `NetworkTargetDict.uplinks: NotRequired[list[list[str]]]`: one group per way out of the bridge, a bond's slaves together (`[["eno1", "eno2"]]`), a single NIC alone (`[["eno1"]]`). Internal, VLAN and virtual ports are no uplinks. A missing key means the driver cannot tell; `[]` is a bridge without uplink. - Grouped because a bond is one link: lldpd often reports a neighbour on one slave only, and the caller may let that one speak for the bond. Flat, a bond and two separate NICs looked the same. - `get_network_targets` docstring, README hypervisor example, CHANGELOG under Unreleased. - The models.py docstring was tightened so the file stays at its ratchet cap (1504 lines). ## Tests - `tests/test_network_target_uplinks.py`: the key is optional and typed `list[list[str]]`; the core keys stay required. - pytest 863 passed; ruff, ruff format, mypy clean; `napalm-standard check` meets the standard, `ratchet` within the baseline. Implemented by napalm-proxmox (PR follows). Priority: P4.
christianmanivong added 1 commit 2026-10-30 08:27:50 +00:00
feat: NetworkTargetDict.uplinks, the NICs a bridge leaves through (NetOrk/netork#1325)
driver / standard (pull_request) Successful in 18s
driver / lint (pull_request) Successful in 14s
driver / types (pull_request) Successful in 1m1s
driver / test (3.12) (pull_request) Successful in 1m3s
driver / test (3.13) (pull_request) Successful in 59s
driver / lowest (pull_request) Successful in 36s
driver / build (pull_request) Successful in 32s
driver / security (pull_request) Successful in 1m12s
CI / driver (pull_request) Successful in 2m47s
driver / publish (pull_request) Skipped
a5b7b540c6
A VM on a VLAN-aware bridge without a VLAN tag only gets an address when
the switch port behind the bridge carries an untagged network. To find
that port, the caller needs the bridge's physical NICs: their LLDP
neighbours name the switch and the port.

uplinks lists them in groups, one per way out of the bridge: a bond's
slaves together, a single NIC alone. A bond is one link, so a caller can
let one slave's neighbour speak for the others when lldpd sees only one.
Internal, VLAN and virtual ports are no uplinks. A missing key means the
driver cannot tell; an empty list is a bridge without uplink.
christianmanivong added 1 commit 2026-10-30 09:20:52 +00:00
Merge remote-tracking branch 'origin/main' into feat/network-target-uplinks
driver / standard (pull_request) Successful in 24s
driver / lint (pull_request) Successful in 16s
driver / types (pull_request) Successful in 1m2s
driver / test (3.12) (pull_request) Successful in 1m9s
driver / lowest (pull_request) Successful in 32s
driver / test (3.13) (pull_request) Successful in 59s
driver / build (pull_request) Successful in 28s
driver / security (pull_request) Successful in 1m5s
CI / driver (pull_request) Successful in 3m1s
driver / publish (pull_request) Skipped
0dc1a598e2
# Conflicts:
#	CHANGELOG.md
christianmanivong merged commit 551ed0a29d into main 2026-10-30 09:54:19 +00:00
christianmanivong deleted branch feat/network-target-uplinks 2026-10-30 09:54:19 +00:00
Sign in to join this conversation.