NAPALM/napalm-vmware
1
0 Fork 0
Code Issues 1 Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat!: report hosts and licenses as facts, not warnings (0.2.0) #6

Merged
christianmanivong merged 1 commits from feat/facts-not-warnings into main 2026-10-17 08:34:58 +00:00
Conversation 0 Commits 1 Files Changed 10
+154 -100
christianmanivong commented 2026-10-17 07:41:48 +00:00
Owner
Copy link
Copy source

Drops get_device_warnings (parse/warnings.py); netOrk names the warnings from facts with the same reach (NetOrk/netork#1146, NetOrk/netork#1111).

  • get_hypervisor_hosts() (napalm-device-types 4.14): name, connected (None on ESXi — a disconnected host could not have answered), maintenance, config_issues verbatim, managed_by (the managing vCenter, ESXi only; under the vCenter driver every host names it, so None).
  • get_licenses() (LicenseMixin): name, status active, edition = editionKey. The license key is never reported. "Free edition = read-only API" is netOrk's rule now.

One loss: vmware_host_disconnected carried the raw state (notResponding vs disconnected); the contract has only connected, so netOrk says "disconnected" for both.

Requires napalm-device-types >= 4.14.0. Tested against the vcsim fixtures only (no real vSphere, see #305 in netOrk).

Part of #5

Drops `get_device_warnings` (`parse/warnings.py`); netOrk names the warnings from facts with the same reach (NetOrk/netork#1146, NetOrk/netork#1111). - `get_hypervisor_hosts()` (napalm-device-types 4.14): name, `connected` (`None` on ESXi — a disconnected host could not have answered), `maintenance`, `config_issues` verbatim, `managed_by` (the managing vCenter, ESXi only; under the vCenter driver every host names it, so `None`). - `get_licenses()` (`LicenseMixin`): name, status `active`, `edition` = `editionKey`. The license key is never reported. "Free edition = read-only API" is netOrk's rule now. One loss: `vmware_host_disconnected` carried the raw state (`notResponding` vs `disconnected`); the contract has only `connected`, so netOrk says "disconnected" for both. Requires napalm-device-types >= 4.14.0. Tested against the vcsim fixtures only (no real vSphere, see #305 in netOrk). Part of #5
christianmanivong added 1 commit 2026-10-17 07:41:48 +00:00
feat!: report hosts and licenses as facts, not warnings (0.2.0)
CI / test (3.10) (push) Successful in 27s
Details
CI / test (3.11) (push) Successful in 25s
Details
CI / test (3.12) (push) Successful in 27s
Details
CI / test (3.10) (pull_request) Successful in 27s
Details
CI / test (3.11) (pull_request) Successful in 24s
Details
CI / test (3.12) (pull_request) Successful in 26s
Details
990dfe2f3c 
get_device_warnings is gone; netOrk names the warnings from facts
(netOrk #1111). get_hypervisor_hosts() reports each host's connection
state, maintenance mode, configuration issues and managing vCenter;
get_licenses() the assigned licenses with the edition key as edition,
never the key itself.

The reach stays: the ESXi driver reports connected as None (a
disconnected host could not have answered), and managed_by only for a
host it reached directly. parse/warnings.py is replaced by
parse/hosts.py and parse/licenses.py.
christianmanivong merged commit f943fde994 into main 2026-10-17 08:34:58 +00:00
christianmanivong deleted branch feat/facts-not-warnings 2026-10-17 08:34:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-vmware#6