4 Commits

Include renames

Author	SHA1	Message	Date
Christian Manivong	06b446934f	fix: what bandit and the remaining lint rules found ... - zip() in provisioning is strict (B905): the OVF asks for one adapter per requested NIC, so the two lists match. A VM that came back with fewer adapters used to get a seed that left a NIC unconfigured; it now fails, and create_vm_from_cloud_init discards it as on any other error after the import. A test covers it. - A failed abort of the import lease is logged at debug level instead of passed over (B110); the original error is still the one raised. - nosec for false positives, each with its reason: the 0.0.0.0 entries in the parsers are addresses vSphere reports, not binds (B104); qemu-img runs with a fixed argv and no shell (B404, B603); xml.sax.saxutils only escapes the OVF descriptor the driver writes, nothing is parsed (B406), so defusedxml would not apply.	2026-10-23 08:38:41 +02:00
Christian Manivong	b5c830acfe	feat(vm-provision): declare the guest agent per guest OS, Linux only ... Follows napalm-device-types 3.0, which replaces GUEST_AGENT_PACKAGES / GUEST_AGENT_RUNCMD with GUEST_AGENTS = {guest_os: (packages, runcmd)}. VMware lists Linux with open-vm-tools, as before, and refuses any other guest_os before anything is created: BSD guests on VMware are optional for now (NetOrk/netork#801). The NoCloud network-config moved to napalm-device-types (`provisioning.network_config`), which Proxmox now uses as well; the seed module's copy is gone, and the tests check that the generic one is used.	2026-10-08 07:54:13 +02:00
Christian Manivong	4b4410741f	feat(provisioning): accept cpu_type, and refuse one that cannot be honoured ... napalm_device_types' create_vm_from_cloud_init gained cpu_type, the CPU model a new VM gets (netork#494). VMware sets CPU compatibility per cluster (EVC), not per VM, and this driver has no get_vm_cpu_types() to offer a model, so None is the only value it can honour. Anything else raises ValueError before the image is fetched rather than being dropped silently.	2026-10-04 12:02:48 +02:00
Christian Manivong	2b84ceae3a	feat: VM provisioning, and reboot_host on ESXi ... create_vm_from_cloud_init takes the same qcow2/raw cloud images netOrk offers for Proxmox. ESXi can neither boot nor download them, so the driver does both: download with checksum check and one retry, convert with qemu-img to a streamOptimized VMDK (cached by URL), import through a minimal OVF descriptor over NFC, pin requested MACs, grow the disk, and attach a NoCloud seed ISO placed next to the VM's files. NoCloud rather than guestinfo because it needs nothing in the guest; the user-data installs open-vm-tools, which the driver declares as its guest agent. A failure after the import removes the VM again. Placement is a pure decision over inventory rows: a connected host outside maintenance mode that sees the datastore and every port group, with the resource pool and VM folder found by walking up to the datacenter -- one path for a standalone host and for a vCenter. Two faults vcsim surfaced and the tests now pin: a chunked upload body next to a Content-Length is refused with 500, so the disk goes up as a sized file object that also reports lease progress; and a device edit replaces the device as sent, so disk and NIC edits start from the live objects, backing included (vcsim panicked on a disk without one). destroy_vm, get_vm_status, get_network_targets (port groups with their fixed VLAN) and get_image_storages complete the contract. reboot_host on ESXi uses RebootHost_Task and refuses outside maintenance mode: force=True would cut power to running VMs. Tested against vcsim in ESXi and vCenter mode, end to end.	2026-09-24 10:00:33 +02:00