feat: get_clusters() and create_vm_from_cloud_init(node=)
driver / standard (pull_request) Successful in 14s
driver / lint (pull_request) Successful in 13s
driver / types (pull_request) Failing after 1m2s
driver / test (3.12) (pull_request) Failing after 57s
driver / test (3.13) (pull_request) Failing after 52s
driver / lowest (pull_request) Failing after 25s
driver / build (pull_request) Successful in 24s
driver / security (pull_request) Successful in 57s
CI / driver (pull_request) Failing after 2m21s
driver / publish (pull_request) Skipped

vCenter reports each cluster compute resource, and each standalone host
it runs as a cluster of one, identified by "<instanceUuid>/<moref>"; an
ESXi host reports itself. Nodes carry state, maintenance, CPU and memory;
datastores and port groups carry the hosts that see them.

create_vm_from_cloud_init(node=) places the VM on that host and refuses
one that does not exist or cannot take it, before anything is created.
Placement now runs before the image download, so a refused host fails at
once instead of after the download.

Refs NetOrk/netork#484, NetOrk/netork#1822
This commit is contained in:
Christian Manivong committed 2026-11-01 16:38:38 +01:00
1 parent 1bf8de4c23
commit 52c802ed41
14 files changed
+812 -28

No files matched your search

+74
View File
@@ -74,6 +74,7 @@ class TestIdentity:
"get_virtual_networks",
"get_hypervisor_hosts",
"get_licenses",
"get_clusters",
],
)
@pytest.mark.parametrize("cls", DRIVERS)
@@ -248,6 +249,79 @@ class TestVcenterGetters:
assert vcenter.get_virtual_networks()["DC0_DVPG0"]["type"] == "dvportgroup"
def _vcsim_topology(data, compute, clusters, networks):
"""What the harvested fixtures predate: compute resources, Network objects,
and each host's datastores and networks -- as vcsim reports them."""
objects = data["objects"]
objects["ComputeResource"] = compute
objects["ClusterComputeResource"] = [c for c in compute if c["_moref"] in clusters]
objects["Network"] = networks
for host in objects["HostSystem"]:
host["datastore"] = [ds["_moref"] for ds in objects["Datastore"]]
host["network"] = [n["_moref"] for n in networks]
class TestClusters:
@pytest.fixture
def vcenter(self, vcenter_data):
_vcsim_topology(
vcenter_data,
[
{"_moref": "domain-s24", "name": "DC0_H0", "host": ["host-21"]},
{
"_moref": "domain-c28",
"name": "DC0_C0",
"host": ["host-37", "host-47", "host-57"],
},
],
{"domain-c28"},
[
{"_moref": "network-6", "name": "VM Network"},
{"_moref": "dvportgroup-10", "name": "DVS0-DVUplinks-8"},
{"_moref": "dvportgroup-12", "name": "DC0_DVPG0"},
],
)
return _driver(VmwareVcenterDriver, vcenter_data, hostname="vc01.example.lan")
@pytest.fixture
def esxi(self, esxi_data):
_vcsim_topology(
esxi_data,
[{"_moref": "ha-compute-res", "name": "localhost.localdomain", "host": ["ha-host"]}],
set(),
[{"_moref": "HaNetwork-VM Network", "name": "VM Network"}],
)
return _driver(VmwareEsxiDriver, esxi_data)
def test_vcenter_reports_its_cluster_and_its_standalone_host(self, vcenter, vcenter_data):
uuid = vcenter_data["about"]["instanceUuid"]
clusters = vcenter.get_clusters()
assert [(c["name"], c["id"]) for c in clusters] == [
("DC0_C0", f"{uuid}/domain-c28"),
(None, f"{uuid}/domain-s24"),
]
assert [n["name"] for n in clusters[0]["nodes"]] == ["DC0_C0_H0", "DC0_C0_H1", "DC0_C0_H2"]
assert [n["name"] for n in clusters[1]["nodes"]] == ["DC0_H0"]
assert {n["name"] for n in clusters[0]["networks"]} == {"VM Network", "DC0_DVPG0"}
assert clusters[0]["storages"][0]["nodes"] == ["DC0_C0_H0", "DC0_C0_H1", "DC0_C0_H2"]
def test_esxi_is_a_cluster_of_one_with_itself_local(self, esxi, esxi_host):
(cluster,) = esxi.get_clusters()
assert (cluster["id"], cluster["name"]) == (esxi_host["hardware.systemInfo"]["uuid"], None)
assert [(n["name"], n["local"], n["status"]) for n in cluster["nodes"]] == [
(esxi_host["name"], True, "online")
]
assert [s["name"] for s in cluster["storages"]] == ["LocalDS_0"]
assert [n["name"] for n in cluster["networks"]] == ["VM Network"]
@pytest.mark.parametrize("name", ["vcenter", "esxi"])
def test_a_failed_read_raises_instead_of_reporting_nothing(self, request, name):
driver = request.getfixturevalue(name)
driver._inventory.collect = MagicMock(side_effect=RuntimeError("session gone"))
with pytest.raises(RuntimeError, match="session gone"):
driver.get_clusters()
class TestFindVm:
def test_by_name_vmid_or_moref(self, esxi, esxi_data):
vm0 = esxi_data["objects"]["VirtualMachine"][0]