Files
napalm-tplink-jetstream/napalm_tplink_jetstream/_ssh.py
T
Christian Manivong d14c11e991
driver / lint (pull_request) Successful in 14s
driver / standard (pull_request) Successful in 19s
driver / types (pull_request) Successful in 1m9s
driver / test (3.13) (pull_request) Successful in 58s
driver / test (3.12) (pull_request) Successful in 1m7s
driver / lowest (pull_request) Successful in 28s
driver / build (pull_request) Successful in 33s
driver / security (pull_request) Successful in 1m8s
CI / driver (pull_request) Successful in 2m25s
driver / publish (pull_request) Skipped
fix(ssh): keep the key exchange off DH group16
The switch offers diffie-hellman-group14-sha256 and group16-sha512 only,
and paramiko picks group16. On an SG2210P with firmware 5.30 that 4096-bit
exchange takes 9 to 16 seconds, against netmiko's 10-second conn_timeout:
paramiko then tries to log in on a transport whose key exchange has not
finished and fails with "No existing session", so every other poll failed
and netOrk flapped the switch between online and offline. group14 takes
1.5 seconds.

group16 is now disabled by default; a disabled_algorithms passed in
optional_args still wins. The netmiko arguments move into _ssh.py, so
tplink_jetstream.py keeps its recorded length.
2026-10-30 09:17:48 +01:00

20 lines
761 B
Python

"""What the driver hands netmiko for the SSH connection."""
from __future__ import annotations
from typing import Any
from napalm.base.netmiko_helpers import netmiko_args
#: The switch offers DH group14 and group16 only, and paramiko picks group16. Its
#: 4096-bit exchange takes 9-16 s on an SG2210P with firmware 5.30, against
#: netmiko's 10 s conn_timeout; group14 takes 1.5 s.
SLOW_KEX: dict[str, list[str]] = {"kex": ["diffie-hellman-group16-sha512"]}
def netmiko_connect_args(optional_args: dict[str, Any]) -> dict[str, Any]:
"""netmiko's share of ``optional_args``, without group16 unless the caller says otherwise."""
args: dict[str, Any] = netmiko_args(optional_args)
args.setdefault("disabled_algorithms", SLOW_KEX)
return args