fix(ping): "Request timed out" lines no longer go into results, so a host that only times out is not reported alive (#2).
fix(snmp): without a listed community, get_snmp_config reports running=False, community="" instead of inventing "public" (#3). The issue's second point (management VLAN substring match) is already fixed on main by c2f0f7c (exact match, caller's listen preferred); the device-types floor is in pyproject since 4e171bf.
fix(snmp): the community is read from the Name column — the recorded show snmp-server community table starts with an Index column, so get_snmp_config reported 1 as the community (found while recording fixtures for #3).
Tested: against the recorded community table plus fixtures. pytest 54 passed, ruff, mypy, napalm-standard check/ratchet green.
Two bug fixes, one commit each.
- `fix(ping)`: "Request timed out" lines no longer go into `results`, so a host that only times out is not reported alive (#2).
- `fix(snmp)`: without a listed community, `get_snmp_config` reports `running=False, community=""` instead of inventing "public" (#3). The issue's second point (management VLAN substring match) is already fixed on main by c2f0f7c (exact match, caller's `listen` preferred); the device-types floor is in pyproject since 4e171bf.
- `fix(snmp)`: the community is read from the Name column — the recorded `show snmp-server community` table starts with an Index column, so `get_snmp_config` reported `1` as the community (found while recording fixtures for #3).
Tested: against the recorded community table plus fixtures. pytest 54 passed, ruff, mypy, `napalm-standard check`/`ratchet` green.
Closes #2
Closes #3
Each "Request timed out" line went into results with the timeout as its
RTT. NAPALM's results hold replies, and a sweep treats a non-empty
results list as a live host, so dead hosts showed up in LAN scans.
Closes#2
get_snmp_config started from community "public" and returned it with
running=True when no row of the community table parsed. Without a listed
community it now reports the agent as not running, as it already did for
"no community entry exists".
The issue's other two points were already fixed on main: the management
VLAN is matched exactly since c2f0f7c (_management_vlan, with the
caller's listen address), and the floor on napalm-device-types is 4.21.1
with no requirements.txt since 4e171bf.
Closes#3
The switch's community table starts with an Index column, and
get_snmp_config took a row's first word, so it reported the community
as "1". The name now comes from the column headed Name, found in the
header line above the dashes; the tests read the recorded table.
Found while recording fixtures for #3.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Two bug fixes, one commit each.
fix(ping): "Request timed out" lines no longer go intoresults, so a host that only times out is not reported alive (#2).fix(snmp): without a listed community,get_snmp_configreportsrunning=False, community=""instead of inventing "public" (#3). The issue's second point (management VLAN substring match) is already fixed on main byc2f0f7c(exact match, caller'slistenpreferred); the device-types floor is in pyproject since4e171bf.fix(snmp): the community is read from the Name column — the recordedshow snmp-server communitytable starts with an Index column, soget_snmp_configreported1as the community (found while recording fixtures for #3).Tested: against the recorded community table plus fixtures. pytest 54 passed, ruff, mypy,
napalm-standard check/ratchetgreen.Closes #2
Closes #3