NAPALM/napalm-tplink-jetstream
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare commits

base: NAPALM/napalm-tplink-jetstream:a772b0f967e3d165de9a02c2a77eb39911e98c20
Branches Tags
NAPALM/napalm-tplink-jetstream:main
...
compare: NAPALM/napalm-tplink-jetstream:main
Branches Tags
NAPALM/napalm-tplink-jetstream:main
2 Commits
a772b0f967 ... main
Author SHA1 Message Date
christianmanivong e8c8515984 Merge pull request 'ci: install napalm-device-types from git, so the tests run at all' (#1) from fix/ci-device-types-from-git into main
Tests / Test (Python 3.10) (push) Successful in 16s
Details
Tests / Test (Python 3.11) (push) Successful in 16s
Details
Tests / Test (Python 3.12) (push) Successful in 20s
Details
2026-10-03 23:23:38 +00:00
Christian Manivong 786f05faac ci: install napalm-device-types from git, so the tests run at all
Tests / Test (Python 3.10) (pull_request) Successful in 17s
Details
Tests / Test (Python 3.11) (pull_request) Successful in 16s
Details
Tests / Test (Python 3.12) (pull_request) Successful in 21s
Details 
Every CI run died at "pip install -e .[dev]": pyproject.toml asks for
napalm_device_types, which lives in git.netork.io/NAPALM rather than on PyPI,
and pip found only an unrelated 0.1.0 there. Not one test had run in CI.

The workflow now installs napalm-device-types from git first. The matrix
drops 3.8/3.9 and requires-python says >=3.10, because napalm-device-types
itself needs 3.10 -- the package never installed on anything older.

Replayed in a fresh venv: napalm-device-types 2.0.0 from git, then the
package with its dev extras, tests green.
 2026-10-04 00:43:46 +02:00
2 changed files with 5 additions and 4 deletions
Expand all files Collapse all files
.github/workflows/tests.yml
+4 -1
View File
@@ -13,7 +13,7 @@ jobs:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"] python-version: ["3.10", "3.11", "3.12"]
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
@@ -25,6 +25,9 @@ jobs:
- name: Install dependencies - name: Install dependencies
run: | run: |
# napalm-device-types lives in git.netork.io/NAPALM, not on PyPI: without this
# pip looks there, finds an unrelated 0.1.0 and the job dies before any test.
pip install "napalm-device-types @ git+https://git.netork.io/NAPALM/napalm-device-types.git"
pip install -e ".[dev]" pip install -e ".[dev]"
- name: Run tests - name: Run tests
pyproject.toml
+1 -3
View File
@@ -8,7 +8,7 @@ version = "0.1.2"
description = "NAPALM driver for TP-Link Jetstream managed switches" description = "NAPALM driver for TP-Link Jetstream managed switches"
readme = "README.md" readme = "README.md"
license = { text = "Apache-2.0" } license = { text = "Apache-2.0" }
requires-python = ">=3.8" requires-python = ">=3.10"
authors = [ authors = [
{ name = "Christian Manivong" }, { name = "Christian Manivong" },
] ]
@@ -16,8 +16,6 @@ classifiers = [
"Topic :: Utilities", "Topic :: Utilities",
"License :: OSI Approved :: Apache Software License", "License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3", "Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12", "Programming Language :: Python :: 3.12",