style: ruff format and the lint rules of the driver standard
Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff cannot fix comes in the next commit.
This commit is contained in:
1 parent
8b94818269
commit
e53a4b4cc6
5 files changed
+119
-81
No files matched your search
+22
-11
@@ -1,15 +1,16 @@
|
||||
"""Unit tests for TPLinkJetstreamDriver — no real device required."""
|
||||
|
||||
import pytest
|
||||
from unittest.mock import MagicMock, patch
|
||||
|
||||
from napalm_tplink_jetstream.tplink_jetstream import TPLinkJetstreamDriver
|
||||
import pytest
|
||||
|
||||
from napalm_tplink_jetstream.tplink_jetstream import TPLinkJetstreamDriver
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Fixtures
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def driver():
|
||||
"""Return a driver instance with a mocked Netmiko connection."""
|
||||
@@ -83,12 +84,11 @@ Gi1/0/1 00-AA-BB-CC-DD-EE Gi0/1 10.0.0.1 uplink
|
||||
"""
|
||||
|
||||
|
||||
|
||||
|
||||
# ---------------------------------------------------------------------------
|
||||
# Tests
|
||||
# ---------------------------------------------------------------------------
|
||||
|
||||
|
||||
class TestGetFacts:
|
||||
def test_returns_required_keys(self, driver):
|
||||
driver.device.send_command.return_value = SHOW_SYSTEM_INFO
|
||||
@@ -100,8 +100,16 @@ class TestGetFacts:
|
||||
)
|
||||
|
||||
facts = driver.get_facts()
|
||||
for key in ("vendor", "model", "hostname", "os_version", "serial_number",
|
||||
"uptime", "interface_list", "fqdn"):
|
||||
for key in (
|
||||
"vendor",
|
||||
"model",
|
||||
"hostname",
|
||||
"os_version",
|
||||
"serial_number",
|
||||
"uptime",
|
||||
"interface_list",
|
||||
"fqdn",
|
||||
):
|
||||
assert key in facts
|
||||
|
||||
def test_vendor(self, driver):
|
||||
@@ -257,11 +265,14 @@ class TestIsAlive:
|
||||
|
||||
|
||||
class TestUptimeParser:
|
||||
@pytest.mark.parametrize("uptime_str,expected", [
|
||||
("0 day(s) 0 hour(s) 0 min(s) 0 sec(s)", 0),
|
||||
("1 day(s) 0 hour(s) 0 min(s) 0 sec(s)", 86400),
|
||||
("5 day(s) 2 hour(s) 35 min(s) 16 sec(s)", 5 * 86400 + 2 * 3600 + 35 * 60 + 16),
|
||||
])
|
||||
@pytest.mark.parametrize(
|
||||
"uptime_str,expected",
|
||||
[
|
||||
("0 day(s) 0 hour(s) 0 min(s) 0 sec(s)", 0),
|
||||
("1 day(s) 0 hour(s) 0 min(s) 0 sec(s)", 86400),
|
||||
("5 day(s) 2 hour(s) 35 min(s) 16 sec(s)", 5 * 86400 + 2 * 3600 + 35 * 60 + 16),
|
||||
],
|
||||
)
|
||||
def test_parse_uptime_seconds(self, uptime_str, expected):
|
||||
result = TPLinkJetstreamDriver._parse_uptime_seconds(uptime_str)
|
||||
assert result == float(expected)
|
||||
|
||||
@@ -35,9 +35,11 @@ def driver():
|
||||
d._exit_config_mode = MagicMock()
|
||||
d._save_config = MagicMock()
|
||||
d._send_command = MagicMock(
|
||||
side_effect=lambda cmd: SHOW_IP_INTERFACE
|
||||
if cmd == "show ip interface"
|
||||
else "Index Community-Name Access\n1 c0mm read-only\n"
|
||||
side_effect=lambda cmd: (
|
||||
SHOW_IP_INTERFACE
|
||||
if cmd == "show ip interface"
|
||||
else "Index Community-Name Access\n1 c0mm read-only\n"
|
||||
)
|
||||
)
|
||||
return d
|
||||
|
||||
|
||||
@@ -24,7 +24,9 @@ HANDLER = "napalm_tplink_jetstream.tplink_jetstream.ConnectHandler"
|
||||
|
||||
def _device() -> MagicMock:
|
||||
device = MagicMock()
|
||||
device.remote_conn_pre.get_transport.return_value.get_remote_server_key.return_value = SERVER_KEY
|
||||
device.remote_conn_pre.get_transport.return_value.get_remote_server_key.return_value = (
|
||||
SERVER_KEY
|
||||
)
|
||||
return device
|
||||
|
||||
|
||||
|
||||
Reference in new issue
Block a user