Part of #2: media controls refuse when not connected, get_arp_table takes NAPALM's vrf argument, and the module docstring is the module's __doc__ again.
play, pause, stop, next_track, previous_track, set_volume, set_mute raise ConnectionClosedException when not connected instead of returning silently.
Still open in #2 (so it stays open): wired speakers still never report eth0. Renaming the attribute does not help — in SoCo 0.31.2 deviceProperties is a UPnP service object, not a dict with WifiMode, and nothing in SoCo exposes wired vs. wireless. A real fix needs a recording from a wired speaker (e.g. ZoneGroupTopology GetZoneGroupState).
Part of #2: media controls refuse when not connected, `get_arp_table` takes NAPALM's `vrf` argument, and the module docstring is the module's `__doc__` again.
- `play`, `pause`, `stop`, `next_track`, `previous_track`, `set_volume`, `set_mute` raise `ConnectionClosedException` when not connected instead of returning silently.
**Still open in #2 (so it stays open):** wired speakers still never report `eth0`. Renaming the attribute does not help — in SoCo 0.31.2 `deviceProperties` is a UPnP service object, not a dict with `WifiMode`, and nothing in SoCo exposes wired vs. wireless. A real fix needs a recording from a wired speaker (e.g. ZoneGroupTopology `GetZoneGroupState`).
Tested: fixtures only. pytest 33 passed, ruff, mypy, `napalm-standard check`/`ratchet` green.
Refs #2
play() and the other controls returned silently without a device, so
a control that did nothing looked like it had worked. They now raise
ConnectionClosedException. get_arp_table() takes NAPALM's vrf
argument, and the module docstring moves above the imports so
__doc__ is set again.
The wired-speaker part of the issue stays open: SoCo's
deviceProperties is a UPnP service, not a dict with WifiMode, so
renaming the attribute alone would still never report eth0.
Refs #2
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Part of #2: media controls refuse when not connected,
get_arp_tabletakes NAPALM'svrfargument, and the module docstring is the module's__doc__again.play,pause,stop,next_track,previous_track,set_volume,set_muteraiseConnectionClosedExceptionwhen not connected instead of returning silently.Still open in #2 (so it stays open): wired speakers still never report
eth0. Renaming the attribute does not help — in SoCo 0.31.2devicePropertiesis a UPnP service object, not a dict withWifiMode, and nothing in SoCo exposes wired vs. wireless. A real fix needs a recording from a wired speaker (e.g. ZoneGroupTopologyGetZoneGroupState).Tested: fixtures only. pytest 33 passed, ruff, mypy,
napalm-standard check/ratchetgreen.Refs #2