get_interfaces_ip reports a guessed prefix length; cli answers [] instead of refusing #15

Closed
opened 2026-11-12 18:14:28 +00:00 by christianmanivong · 0 comments
Owner

Priority: P4 (neither important nor urgent).

Found while fixing #13 (PR #14), in napalm_sonos/sonos_driver.py:

  • get_interfaces_ip always reports prefix_length: 24, a guess presented as a reading. A speaker in a /23 or /25 network is reported wrongly. Either read the real prefix, or leave the getter to NAPALM's stub if the speaker does not say.
  • cli() returns []. NAPALM's cli contract returns a dict, and a driver without a CLI should keep NAPALM's NotImplementedError stub (STANDARDS §3), as #14 did for the getters.
Priority: P4 (neither important nor urgent). Found while fixing #13 (PR #14), in `napalm_sonos/sonos_driver.py`: - `get_interfaces_ip` always reports `prefix_length: 24`, a guess presented as a reading. A speaker in a /23 or /25 network is reported wrongly. Either read the real prefix, or leave the getter to NAPALM's stub if the speaker does not say. - `cli()` returns `[]`. NAPALM's `cli` contract returns a dict, and a driver without a CLI should keep NAPALM's `NotImplementedError` stub (STANDARDS §3), as #14 did for the getters.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-sonos#15