Proxmox Backup Server speaks the same REST dialect, logs in the same way and runs on Debian too, so what a second driver needs moves out of ProxmoxDriver first: - napalm_proxmox._base: the connection (proxmoxer service PVE or PBS, each with its port), the token split, the SSH session, run_command, the node helpers and the DMI read. - napalm_proxmox.host_mixin: packages and APT updates, the subscription, restart and shutdown through the API, root file writes and the transports of the host readers (kernel, listening sockets, identity, systemd, host status, apt's proxy). The PVE driver behaves as before; what it hands proxmoxer is pinned by tests first, and it now names service="PVE" explicitly. get_packages is split so the dpkg line parser stands alone; get_facts and get_packages leave the quality baseline.
68 lines
2.8 KiB
Python
68 lines
2.8 KiB
Python
"""`get_packages` and the source coordinate OSV matching needs.
|
|
|
|
A Proxmox node is a Debian host, so its packages are matched against Debian
|
|
advisories — and OSV states those ranges in *source* package versions. Reporting
|
|
the source package without its version leaves a consumer holding two numbers on
|
|
different axes: `libldb2` is `2:2.11.0+samba4.22.11+dfsg-…` while its source,
|
|
samba, is `2:4.22.11+dfsg-…`, and comparing the first against a samba range is
|
|
meaningless.
|
|
|
|
Measured before this was fixed: on three Proxmox nodes, **every one** of their
|
|
2 349 packages carried a source package and no source version — 802 of 802,
|
|
774 of 774, 773 of 773 — while twenty non-Proxmox hosts had both. The format
|
|
string simply never asked for the field.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
# `${Package}\t${Version}\t${db:Status-Status}\t${Installed-Size}\t${source:Package}\t${source:Version}`
|
|
DPKG = (
|
|
"openssh-server\t1:9.2p1-2\tinstalled\t1024\topenssh\t1:9.2p1-2\n"
|
|
"libldb2\t2:2.11.0+samba4.22.11+dfsg-0+deb13u1\tinstalled\t512\tsamba\t2:4.22.11+dfsg-0+deb13u1\n"
|
|
"curl\t7.88.1-10\tinstalled\t256\t\t\n"
|
|
)
|
|
|
|
|
|
@pytest.mark.parametrize("driver_with_exec", [DPKG], indirect=True)
|
|
def test_the_source_version_is_reported(driver_with_exec):
|
|
"""The field the whole fix is about."""
|
|
packages = {p["name"]: p for p in driver_with_exec.get_packages()}
|
|
|
|
assert packages["libldb2"]["source_package"] == "samba"
|
|
assert packages["libldb2"]["source_version"] == "2:4.22.11+dfsg-0+deb13u1"
|
|
|
|
|
|
@pytest.mark.parametrize("driver_with_exec", [DPKG], indirect=True)
|
|
def test_the_binary_version_is_kept_beside_it(driver_with_exec):
|
|
"""Both are wanted: one says what is installed, the other is the axis the
|
|
advisory's range is stated on."""
|
|
libldb2 = {p["name"]: p for p in driver_with_exec.get_packages()}["libldb2"]
|
|
|
|
assert libldb2["version"] == "2:2.11.0+samba4.22.11+dfsg-0+deb13u1"
|
|
|
|
|
|
@pytest.mark.parametrize("driver_with_exec", [DPKG], indirect=True)
|
|
def test_an_empty_source_falls_back_to_the_package_itself(driver_with_exec):
|
|
"""dpkg leaves both fields empty when the source is the package — and an
|
|
older dpkg leaves them empty because it does not know the field at all.
|
|
Neither may produce a package with no coordinate."""
|
|
curl = {p["name"]: p for p in driver_with_exec.get_packages()}["curl"]
|
|
|
|
assert curl["source_package"] == "curl"
|
|
assert curl["source_version"] == "7.88.1-10"
|
|
|
|
|
|
def test_the_query_asks_for_the_field():
|
|
"""The defect was in the format string, not in the parsing: the driver
|
|
reported a source package it had asked for and a source version it had
|
|
not, so no amount of parsing could have produced one."""
|
|
import inspect
|
|
|
|
from napalm_proxmox import host_mixin
|
|
|
|
source = inspect.getsource(host_mixin.ProxmoxHostMixin.get_packages)
|
|
|
|
assert "source:Version" in source
|