proxmox_backup: check and report the server's TLS certificate (CertificateCheck) #60

Open
opened 2026-11-03 05:00:11 +00:00 by christianmanivong · 0 comments
Owner

Priority: P3 (important, not urgent): the backup server connects with verification off on a self-signed certificate, and netOrk's certificate store learns nothing about it.

ProxmoxBackupDriver (and ProxmoxDriver) ignore optional_args["tls_fingerprints"] and tls_certificate_observer (napalm-device-types tls_certificates, procurve#17). With verify_ssl off a wrong host gets the API token, and netOrk keeps no TLS fingerprint for the device.

Seen on 2026-11-03 (NetOrk/netork#1919): a PVE pbs storage pins the PBS's fingerprint, but netOrk has no TLS key for the proxmox_backup device to compare it with, so netOrk ties the storage to the server by host and port instead.

What

Use CertificateCheck in ProxmoxBase.open(): verify_server before the first request when verify_ssl is off, pin on the requests session proxmoxer uses, observations to the observer. Both products share the base, so PVE gets it too.

Test-First

  • a known fingerprint and another certificate → TlsCertificateMismatch before any request with the token
  • no fingerprint → first use accepted and reported to the observer
  • neither argument → connects as today
Priority: P3 (important, not urgent): the backup server connects with verification off on a self-signed certificate, and netOrk's certificate store learns nothing about it. `ProxmoxBackupDriver` (and `ProxmoxDriver`) ignore `optional_args["tls_fingerprints"]` and `tls_certificate_observer` (napalm-device-types `tls_certificates`, procurve#17). With `verify_ssl` off a wrong host gets the API token, and netOrk keeps no TLS fingerprint for the device. Seen on 2026-11-03 (NetOrk/netork#1919): a PVE `pbs` storage pins the PBS's fingerprint, but netOrk has no TLS key for the `proxmox_backup` device to compare it with, so netOrk ties the storage to the server by host and port instead. ## What Use `CertificateCheck` in `ProxmoxBase.open()`: `verify_server` before the first request when `verify_ssl` is off, `pin` on the requests session proxmoxer uses, observations to the observer. Both products share the base, so PVE gets it too. ## Test-First - [ ] a known fingerprint and another certificate → `TlsCertificateMismatch` before any request with the token - [ ] no fingerprint → first use accepted and reported to the observer - [ ] neither argument → connects as today
christianmanivong added the
prio
P3
enhancement
labels 2026-11-03 05:00:11 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-proxmox#60