get_dhcp_leases returns [] when Kea, ISC and the ARP fallback all fail #27

New Issue

2026-10-20T22:28:25Z

christianmanivong commented

2026-10-20 22:28:25 +00:00

Priority: P2 (important and urgent — blocks NetOrk/netork#1189).

get_dhcp_leases() (napalm_opnsense/opnsense.py, ~L1309-1385) tries Kea, then ISC, then the ARP table as a fallback. When all three fail, the last except logs and returns [].

netOrk is changing its poll so that a failed read (None / exception) keeps the stored leases and an empty list means "the server has no leases" and clears them (NetOrk/netork#1189). With the current driver, an outage of the firewall's API during a poll would then delete every stored lease of that firewall.

Fix: raise (e.g. RuntimeError naming all three failures) when no source could be read; return [] only when a source answered and had nothing. Note that Kea/ISC answering [] currently falls through to the ARP fallback — keep that behaviour unless a source answered successfully with no leases and the others failed; document the decision in the docstring.

Found during NetOrk/netork#1189 (2026-10-21).

**Priority: P2** (important and urgent — blocks NetOrk/netork#1189). `get_dhcp_leases()` (`napalm_opnsense/opnsense.py`, ~L1309-1385) tries Kea, then ISC, then the ARP table as a fallback. When all three fail, the last `except` logs and returns `[]`. netOrk is changing its poll so that a failed read (`None` / exception) keeps the stored leases and an empty list means "the server has no leases" and clears them (NetOrk/netork#1189). With the current driver, an outage of the firewall's API during a poll would then delete every stored lease of that firewall. **Fix:** raise (e.g. `RuntimeError` naming all three failures) when no source could be read; return `[]` only when a source answered and had nothing. Note that Kea/ISC answering `[]` currently falls through to the ARP fallback — keep that behaviour unless a source answered successfully with no leases and the others failed; document the decision in the docstring. Found during NetOrk/netork#1189 (2026-10-21).

christianmanivong referenced this issue from a commit

2026-10-20 23:02:00 +00:00

fix: get_dhcp_leases raises when no lease source answered (#27)

christianmanivong referenced a pull request that will close this issue

2026-10-20 23:02:27 +00:00

fix: get_dhcp_leases raises when no lease source answered (#27) #29

christianmanivong closed this issue

2026-10-20 23:36:59 +00:00

christianmanivong referenced this issue from a commit

2026-10-20 23:36:59 +00:00

Merge pull request 'fix: get_dhcp_leases raises when no lease source answered (#27)' (#29) from fix/dhcp-leases-raise-when-unread into master

Sign in to join this conversation.