From b0270d3430b80c9b0535e2afc7fb8225421e38db Mon Sep 17 00:00:00 2001 From: Christian Manivong Date: Fri, 30 Oct 2026 08:37:08 +0100 Subject: [PATCH] fix: an unknown ARP age is -1.0, not 0.0 Neither ip neigh nor /proc/net/arp has an age, so get_arp_table reports ARP_AGE_UNKNOWN instead of 0.0 ("confirmed just now"). NetOrk/netork#1327 --- CHANGELOG.md | 5 +++++ napalm_openwrt/interfaces_mixin.py | 4 ++-- tests/unit/test_driver.py | 13 +++++++++++++ 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 39de4cf..0d0cf84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,11 @@ recorded here; their history is the git log. - The floor on napalm is 5.1: older releases import `pkg_resources`, which a Python 3.12 venv no longer has. +### Fixed +- `get_arp_table()` reports an unknown age as `-1.0` (napalm-device-types' + `ARP_AGE_UNKNOWN`) instead of `0.0`, which means "confirmed just now": neither + `ip neigh` nor `/proc/net/arp` has an age (NetOrk/netork#1327). + ## [0.7.0] - 2026-10-23 The first release on PyPI. diff --git a/napalm_openwrt/interfaces_mixin.py b/napalm_openwrt/interfaces_mixin.py index 43a4824..62e6979 100644 --- a/napalm_openwrt/interfaces_mixin.py +++ b/napalm_openwrt/interfaces_mixin.py @@ -234,7 +234,7 @@ class OpenWrtInterfaceMixin: "interface": interface, "mac": mac_addr, "ip": ip_addr, - "age": 0.0, + "age": -1.0, # no age reported: unknown, never 0.0 ("just now") } ) continue @@ -267,7 +267,7 @@ class OpenWrtInterfaceMixin: "interface": interface, "mac": mac_addr, "ip": ip_addr, - "age": 0.0, + "age": -1.0, # no age reported: unknown, never 0.0 ("just now") } ) diff --git a/tests/unit/test_driver.py b/tests/unit/test_driver.py index a5f9b75..20fa1f4 100644 --- a/tests/unit/test_driver.py +++ b/tests/unit/test_driver.py @@ -274,6 +274,19 @@ class TestGetArpTable: assert "192.168.1.100" in ips assert "192.168.1.101" in ips + def test_ip_neigh_reports_no_age(self, driver): + # REACHABLE or STALE, `ip neigh` says nothing about when the neighbour + # was last confirmed; 0.0 would read as "just now" (NetOrk/netork#1327). + driver._send_command = lambda cmd, **kw: IP_NEIGH_SHOW + assert {e["age"] for e in driver.get_arp_table()} == {-1.0} + + def test_proc_net_arp_reports_no_age(self, driver): + driver._send_command = lambda cmd, **kw: ( + "IP address HW type Flags HW address Mask Device\n" + "192.168.1.100 0x1 0x2 aa:bb:cc:dd:ee:ff * br-lan\n" + ) + assert [e["age"] for e in driver.get_arp_table()] == [-1.0] + class TestGetMacAddressTable: def test_returns_list(self, driver): -- 2.54.1