NAPALM/napalm-openwrt
1
0 Fork 0
Code Issues 8 Pull Requests Actions Packages Projects Releases Wiki Activity

feat: name only a missing base64; lldpd, auc and updates are facts (0.3.0) #15

Merged
christianmanivong merged 1 commits from feat/facts-not-warnings into master 2026-10-17 08:34:57 +00:00
Conversation 0 Commits 1 Files Changed 3
+53 -62
christianmanivong commented 2026-10-17 07:38:01 +00:00
Owner
Copy link
Copy source

get_device_warnings no longer names lldpd_not_installed, updates_available or update_notifications_disabled. The installed packages and get_available_updates() are the facts; netOrk derives the warnings with the same reach (access points that can install packages; auc only on opkg releases) — NetOrk/netork#1146, NetOrk/netork#1111. The old update read swallowed failures; get_available_updates raises them.

no_base64 stays for now: BusyBox may provide base64 as an applet, so no package tells the caller whether it is there. It goes once the shell commands netOrk sends through _send_command (the UCI apply that needs base64) get a public method.

Checked against the four APs on the test server: apk releases with lldpd installed, so neither path warns.

Part of #13

`get_device_warnings` no longer names `lldpd_not_installed`, `updates_available` or `update_notifications_disabled`. The installed packages and `get_available_updates()` are the facts; netOrk derives the warnings with the same reach (access points that can install packages; `auc` only on opkg releases) — NetOrk/netork#1146, NetOrk/netork#1111. The old update read swallowed failures; `get_available_updates` raises them. `no_base64` stays for now: BusyBox may provide `base64` as an applet, so no package tells the caller whether it is there. It goes once the shell commands netOrk sends through `_send_command` (the UCI apply that needs base64) get a public method. Checked against the four APs on the test server: apk releases with lldpd installed, so neither path warns. Part of #13
christianmanivong added 1 commit 2026-10-17 07:38:01 +00:00
feat: name only a missing base64; lldpd, auc and updates are facts (0.3.0)
CI / test (3.10) (push) Successful in 26s
Details
CI / test (3.11) (push) Successful in 23s
Details
CI / test (3.12) (push) Successful in 26s
Details
CI / test (3.10) (pull_request) Successful in 24s
Details
CI / test (3.11) (pull_request) Successful in 22s
Details
CI / test (3.12) (pull_request) Successful in 25s
Details
34d80bd994 
get_device_warnings no longer names lldpd_not_installed,
updates_available or update_notifications_disabled. The packages and
get_available_updates are the facts; netOrk derives the warnings with the
same reach (netOrk #1111). The old update read swallowed failures,
get_available_updates raises them.

no_base64 stays: BusyBox may provide base64 as an applet, so no package
tells the caller whether it is there.
christianmanivong merged commit 100a6d36c5 into master 2026-10-17 08:34:57 +00:00
christianmanivong deleted branch feat/facts-not-warnings 2026-10-17 08:34:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is broken
 enhancement
New feature or request
 tech-debt
Refactoring / cleanup / deferred debt
prio
P0
Road blocker: blocks other work, drop everything
prio
P1
Critical
prio
P2
Important and urgent
prio
P3
Important, not urgent
prio
P4
Neither important nor urgent
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
christianmanivong
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#15