apply_updates reports success whatever happened #11

Closed
opened 2026-10-14 08:58:51 +00:00 by christianmanivong · 0 comments
Owner

system_mixin.py ~668-681 runs apk upgrade …/opkg upgrade … and returns {"success": True, "output": output} without looking at the exit status. A failed upgrade is reported as done. Same pattern as #3 (manage_service). Fix: use the _RC_MARKER exit status the file already has.

Prio P3.

`system_mixin.py` ~668-681 runs `apk upgrade …`/`opkg upgrade …` and returns `{"success": True, "output": output}` without looking at the exit status. A failed upgrade is reported as done. Same pattern as #3 (`manage_service`). Fix: use the `_RC_MARKER` exit status the file already has. Prio P3.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-openwrt#11