get_device_warnings drops inherited warnings and misses updates on a German host #5

New Issue

2026-10-14T08:58:54Z

christianmanivong commented

2026-10-14 08:58:54 +00:00

openmediavault.py ~90-124 overrides napalm-linux's get_device_warnings:

It returns [] or only updates_available, so every inherited warning is dropped.
It counts with re.search(r'(\d+) upgraded', …) on apt's simulation output, which _sudo runs without a fixed locale. A German host prints "0 aktualisiert"; nothing matches, so no update is ever reported.
It hides held-back packages, although FULL_UPGRADE = True installs exactly those.

With the agnostic structure the method goes (facts instead); until then fix the locale.

Prio P3.

`openmediavault.py` ~90-124 overrides napalm-linux's `get_device_warnings`: - It returns `[]` or only `updates_available`, so every inherited warning is dropped. - It counts with `re.search(r'(\d+) upgraded', …)` on apt's simulation output, which `_sudo` runs without a fixed locale. A German host prints "0 aktualisiert"; nothing matches, so no update is ever reported. - It hides held-back packages, although `FULL_UPGRADE = True` installs exactly those. With the agnostic structure the method goes (facts instead); until then fix the locale. Prio P3.

christianmanivong referenced a pull request that will close this issue

2026-10-17 07:39:16 +00:00

feat: drop the get_device_warnings override; the pending updates are the fact (0.2.0) #7

christianmanivong closed this issue

2026-10-17 08:34:58 +00:00

christianmanivong referenced this issue

2026-10-18 12:44:03 +00:00

Agnostic structure: facts, Linux templates, tracked artefacts #6

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-openmediavault#5