[] is also the answer for a NAS without disks, so the caller cannot tell a failed read from an empty one, against the rule that a failed read raises.
Every smartctl failure (sudo refused, timeout) is caught and logged at debug level (line 246), and the disk is reported with health: "unknown", temperature: -1 — indistinguishable from a disk that has no SMART.
_disk_to_pool swallows a failed /proc/mdstat read the same way.
The contract allows health"healthy", "warning", "failed", "unknown" (napalm_device_types/models.py:907); this driver never reports "warning" (for example reallocated/pending sectors with an overall PASSED). The verdict itself is never found because -iA does not print it — that part is #4.
Expected
A failed lsblk raises.
A failed smartctl call is distinguishable (logged as a warning, or reported per disk), not folded into "unknown".
Once #4 reads the verdict, attributes such as Reallocated_Sector_Ct / Current_Pending_Sector > 0 map to "warning".
Test-first: lsblk output sudo: … raises; a smartctl timeout is logged at warning level.
Priority: P3 — disks vanish from netOrk's view on a transient error, and degraded disks are never flagged.
Found during the bug sweep of 2026-11-01.
## What happens
`get_disks` (`napalm_openmediavault/openmediavault.py` 157-263):
- If `lsblk -J …` fails or prints something that is not JSON, the exception is swallowed and the empty list is returned (lines 195-201):
```python
lsblk = _json.loads(raw)
except Exception:
return result
```
`[]` is also the answer for a NAS without disks, so the caller cannot tell a failed read from an empty one, against the rule that a failed read raises.
- Every `smartctl` failure (sudo refused, timeout) is caught and logged at debug level (line 246), and the disk is reported with `health: "unknown"`, `temperature: -1` — indistinguishable from a disk that has no SMART.
- `_disk_to_pool` swallows a failed `/proc/mdstat` read the same way.
The contract allows `health` `"healthy"`, `"warning"`, `"failed"`, `"unknown"` (`napalm_device_types/models.py:907`); this driver never reports `"warning"` (for example reallocated/pending sectors with an overall PASSED). The verdict itself is never found because `-iA` does not print it — that part is #4.
## Expected
- A failed `lsblk` raises.
- A failed `smartctl` call is distinguishable (logged as a warning, or reported per disk), not folded into "unknown".
- Once #4 reads the verdict, attributes such as Reallocated_Sector_Ct / Current_Pending_Sector > 0 map to `"warning"`.
Test-first: `lsblk` output `sudo: …` raises; a `smartctl` timeout is logged at warning level.
Priority: P3 — disks vanish from netOrk's view on a transient error, and degraded disks are never flagged.
Found during the bug sweep of 2026-11-01.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What happens
get_disks(napalm_openmediavault/openmediavault.py157-263):lsblk -J …fails or prints something that is not JSON, the exception is swallowed and the empty list is returned (lines 195-201):[]is also the answer for a NAS without disks, so the caller cannot tell a failed read from an empty one, against the rule that a failed read raises.smartctlfailure (sudo refused, timeout) is caught and logged at debug level (line 246), and the disk is reported withhealth: "unknown",temperature: -1— indistinguishable from a disk that has no SMART._disk_to_poolswallows a failed/proc/mdstatread the same way.The contract allows
health"healthy","warning","failed","unknown"(napalm_device_types/models.py:907); this driver never reports"warning"(for example reallocated/pending sectors with an overall PASSED). The verdict itself is never found because-iAdoes not print it — that part is #4.Expected
lsblkraises.smartctlcall is distinguishable (logged as a warning, or reported per disk), not folded into "unknown"."warning".Test-first:
lsblkoutputsudo: …raises; asmartctltimeout is logged at warning level.Priority: P3 — disks vanish from netOrk's view on a transient error, and degraded disks are never flagged.
Found during the bug sweep of 2026-11-01.