chore: adopt the NAPALM driver standard
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 12s
driver / types (pull_request) Successful in 55s
driver / test (3.10) (pull_request) Successful in 58s
driver / test (3.11) (pull_request) Successful in 56s
driver / lowest (pull_request) Successful in 26s
driver / test (3.12) (pull_request) Successful in 55s
driver / test (3.13) (pull_request) Successful in 48s
driver / build (pull_request) Successful in 24s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Successful in 3m0s
driver / publish (pull_request) Skipped
driver / standard (pull_request) Successful in 15s
driver / lint (pull_request) Successful in 12s
driver / types (pull_request) Successful in 55s
driver / test (3.10) (pull_request) Successful in 58s
driver / test (3.11) (pull_request) Successful in 56s
driver / lowest (pull_request) Successful in 26s
driver / test (3.12) (pull_request) Successful in 55s
driver / test (3.13) (pull_request) Successful in 48s
driver / build (pull_request) Successful in 24s
driver / security (pull_request) Successful in 58s
CI / driver (pull_request) Successful in 3m0s
driver / publish (pull_request) Skipped
- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow of NAPALM/driver-standard; napalm-device-types and napalm-linux come from git until napalm-linux 0.15.0 is on PyPI. - requires-python >=3.10 (napalm-device-types needs it), SPDX license string, setuptools>=77, LICENSE file, py.typed, links to git.netork.io. - Dependencies: napalm-device-types>=4.22.0, napalm-linux>=0.15.0, napalm>=4.0 (tested at 4.0.0); dev extra with pytest, pytest-cov, mypy and ruff. - mypy strict for the whole package, no exempt module: _omv_read is annotated as returning list[dict[str, Any]] (types only). - Coverage floor 15 % (measured 15.89 %); the four long getters and the complexity of get_disks are recorded in the quality baseline. - README (what it is, how it connects, the getters, what it does not do) and CHANGELOG are new. - The committed egg-info and __pycache__ files are untracked; .gitignore from the template keeps them, .venv and build output out.
This commit is contained in:
1 parent
9fbbd17530
commit
aba36b3b11
20 files changed
+359
-98
No files matched your search
@@ -509,7 +509,7 @@ class OpenMediaVaultDriver(StorageDriver, LinuxDriver):
|
||||
|
||||
# ── Internal helpers ───────────────────────────────────────────────────────
|
||||
|
||||
def _omv_read(self, key: str) -> list:
|
||||
def _omv_read(self, key: str) -> list[dict[str, Any]]:
|
||||
"""Query the OMV config database and return a list of objects.
|
||||
|
||||
Handles both OMV 6+ (returns a JSON array directly) and older
|
||||
@@ -525,7 +525,8 @@ class OpenMediaVaultDriver(StorageDriver, LinuxDriver):
|
||||
# Older OMV wraps the list: {"share": [...]}
|
||||
for wrapper in ("share", "rule", "entry", "mntent", "sharedfolder"):
|
||||
if wrapper in data and isinstance(data[wrapper], list):
|
||||
return data[wrapper]
|
||||
wrapped: list[dict[str, Any]] = data[wrapper]
|
||||
return wrapped
|
||||
return []
|
||||
except Exception:
|
||||
return []
|
||||
|
||||
Reference in new issue
Block a user