5 Commits

Include renames

Author	SHA1	Message	Date
Christian Manivong	6b305c3d47	feat: declare the SNMP health OIDs instead of collecting them (0.2.0) ... netgear_smart no longer collects over SNMP. SNMP_HEALTH_PROFILE states where the switch publishes uptime (standard sysUpTime), memory (total and free in KiB) and CPU (a text value whose five-second figure counts); the application polls and computes (napalm-device-types docs/STRUCTURE.md). Interface counters now come from the 64-bit ifXTable where the switch has it, as the application reads them for every device.	2026-10-16 12:03:00 +02:00
Christian Manivong	efe004a295	fix(lldp): parse the v7 neighbour table, which uses a different command ... get_lldp_neighbors() existed but spoke to the older CLI generation: it ran `show lldp remote-device all` and expected FASTPATH-style `0/1` ports in whitespace-separated columns. v7 firmware answers `Unknown command` — as it does for `show lldp remote-device`, a bare `show lldp`, and the plural `show lldp neighbors`. Only the singular works, though `show ?` lists `lldp` plainly enough: Port | Device ID | Port ID | SysName | ... ---- + ----------------- + ---------------- + ----------------- + ... g9 | 10:01:02:44:37:26 |10:01:02:44:37:28 | pve-eze.eze.local | ... Ports are named g9, and the columns are separated by `|` with irregular padding, so splitting on whitespace tears the values apart. The port ID is not always a port name either — a neighbour may identify its port by MAC. _get_lldp_table() now branches on _detect_cli_v7() into a second parser, the same shape get_mac_address_table() already uses for this divergence. get_lldp_neighbors() itself is untouched. Confirmed against a GS110TPv3 on 7.1.1.17: _detect_cli_v7() returns True there, and the switch reports two neighbours it had never surfaced. Without them NetOrk's map had nothing to draw for the site this switch serves, so four APs and a firewall behind it stood unconnected.	2026-08-18 15:18:56 +07:00
Christian Manivong	5317af0be1	fix(config): drop the uptime line from get_config() ... `show running-config` is preceded by a header block, and one of its lines reports the system uptime. That value necessarily differs between any two reads, so every caller comparing consecutive configs sees a change each time. Measured on a GS110TPv3 under NetOrk: 876 of 894 stored config snapshots marked as changed, one git commit and one config_changed warning per poll, while every other device at the same installation sat between 2 and 18. The history was worthless for that switch — a genuine change would have been invisible among hundreds of uptime diffs. Only the uptime line is removed. Model, firmware version, serial and MAC are stable and belong in a config backup; a changed firmware version is exactly the kind of change worth recording. netgear_plus is unaffected — its get_config() returns empty strings. The first read after this lands reports one real change, since the line disappears from the stored config. That is unavoidable and happens once.	2026-08-18 10:30:11 +07:00
Christian Manivong	46e419d232	fix(get_config): use paged send for show running-config/startup-config ... "v7" CLI firmware has no "terminal length 0" equivalent (see _send_paged_command's docstring), so a config long enough to paginate emits "--More--" prompts that _send_command's expect_string=base_prompt match never sees. On real hardware (GS110TPv3, 7 VLANs, 10 interfaces) this hung every scheduled config-backup poll for 30s and failed with "Pattern not detected: '<prompt>[>#]' in output.", so the config was never actually backed up. get_mac_address_table()/get_vlans() already use _send_paged_command() for the same reason on other long outputs; get_config() now does too. Also fixed tests/unit/test_driver.py's import/patch target (napalm_netgear_plus -> napalm_netgear, the actual package name) — the whole file has been uncollectable since its initial commit, no CI was wired up here to catch it. And removed a dead unreachable `return {"success": ..., "output": ...}` line after get_health_metrics's real return (undefined names, ruff F821), unrelated leftover found while fixing the above.	2026-07-10 09:54:29 +02:00
Christian Manivong	a8ce5a8033	initial commit	2026-05-29 09:13:59 +02:00