From 10a3b1efbfc136266d93c3d32fb49c59344cf7a0 Mon Sep 17 00:00:00 2001 From: Christian Manivong Date: Fri, 23 Oct 2026 08:36:28 +0200 Subject: [PATCH] chore: adopt the NAPALM driver standard - The distribution is renamed to napalm-netgear-switches: napalm-netgear on PyPI belongs to another project. The import package napalm_netgear and the napalm.drivers entry points netgear_smart and netgear_plus stay; [tool.napalm-standard] package names the import package for the check. README install line and CHANGELOG say the new name. - CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow of NAPALM/driver-standard; .github/ is gone. - requires-python >=3.10 (napalm-device-types needs it), floor napalm-device-types>=4.21.1, LICENSE file, py.typed, SPDX license string, links to git.netork.io, a dev extra with floors, CHANGELOG.md. - mypy strict for the package; napalm_netgear.netgear_plus and napalm_netgear.netgear_smart are exempt for now (139 errors), recorded in the quality baseline with their long and complex functions and the 2070-line netgear_smart module. Coverage floor 48 % (measured 48.23 %). Closes #14 --- .gitea/workflows/ci.yml | 15 +++ .github/workflows/ci.yml | 48 --------- CHANGELOG.md | 20 ++++ LICENSE | 191 ++++++++++++++++++++++++++++++++++++ README.md | 18 ++-- napalm_netgear/py.typed | 0 pyproject.toml | 57 ++++++++--- tests/quality_baseline.json | 40 ++++++++ 8 files changed, 320 insertions(+), 69 deletions(-) create mode 100644 .gitea/workflows/ci.yml delete mode 100644 .github/workflows/ci.yml create mode 100644 CHANGELOG.md create mode 100644 LICENSE create mode 100644 napalm_netgear/py.typed create mode 100644 tests/quality_baseline.json diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml new file mode 100644 index 0000000..7530c79 --- /dev/null +++ b/.gitea/workflows/ci.yml @@ -0,0 +1,15 @@ +name: CI + +on: + push: + branches: [main] + tags: ["v*"] + pull_request: + +jobs: + driver: + uses: NAPALM/driver-standard/.gitea/workflows/driver.yml@main + with: + standard-ref: main + secrets: + PYPI_TOKEN: ${{ secrets.PYPI_TOKEN }} diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml deleted file mode 100644 index a7bc4d4..0000000 --- a/.github/workflows/ci.yml +++ /dev/null @@ -1,48 +0,0 @@ -name: CI - -on: - push: - branches: ["**"] - pull_request: - branches: ["**"] - -jobs: - test: - runs-on: ubuntu-latest - strategy: - fail-fast: false - matrix: - python-version: ["3.10", "3.11", "3.12"] - steps: - - name: Checkout - uses: actions/checkout@v4 - - - name: Setup Python - uses: actions/setup-python@v5 - with: - python-version: ${{ matrix.python-version }} - cache: pip - - - name: Install package with dev extras - run: | - python -m pip install --upgrade pip - # napalm-device-types lives in git.netork.io/NAPALM, not on PyPI: without this - # pip looks there, finds an unrelated 0.1.0 and the job dies before any test. - python -m pip install "napalm-device-types @ git+https://git.netork.io/NAPALM/napalm-device-types.git" - python -m pip install -e ".[dev]" - - - name: Run unit tests - run: | - python -m pytest -q --tb=short - - - name: Build wheel and sdist - run: | - python -m pip install build - python -m build - - - name: Upload dist artifacts - # v4 refuses to run on Gitea ("not currently supported on GHES"). - uses: actions/upload-artifact@v3 - with: - name: dist-${{ matrix.python-version }} - path: dist/* \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md new file mode 100644 index 0000000..b5bb46d --- /dev/null +++ b/CHANGELOG.md @@ -0,0 +1,20 @@ +# Changelog + +All notable changes to this driver. The format follows +[Keep a Changelog](https://keepachangelog.com/), versions follow +[Semantic Versioning](https://semver.org/). + +## [Unreleased] + +### Changed +- **The package is now called `napalm-netgear-switches`** on PyPI + (`pip install napalm-netgear-switches`): the name `napalm-netgear` belongs to another + project. The import package `napalm_netgear` and the driver names `netgear_smart` and + `netgear_plus` stay the same. +- The driver follows the NAPALM driver standard + (https://git.netork.io/NAPALM/driver-standard): CI on Gitea runs ruff, mypy, the + tests on Python 3.10–3.13 and at the lowest declared versions, bandit, pip-audit and + a build check, and a release tag publishes to PyPI. The package now ships `py.typed` + and a LICENSE file. **Python 3.8 and 3.9 are no longer supported**; napalm-device-types + never ran on them. It needs napalm-device-types 4.21.1 or later. +- A failed logout when a Netgear Plus session is closed is now logged at debug level. diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000..68d39ec --- /dev/null +++ b/LICENSE @@ -0,0 +1,191 @@ + Apache License + Version 2.0, January 2004 + http://www.apache.org/licenses/ + + TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION + + 1. Definitions. + + "License" shall mean the terms and conditions for use, reproduction, + and distribution as defined by Sections 1 through 9 of this document. + + "Licensor" shall mean the copyright owner or entity authorized by + the copyright owner that is granting the License. + + "Legal Entity" shall mean the union of the acting entity and all + other entities that control, are controlled by, or are under common + control with that entity. For the purposes of this definition, + "control" means (i) the power, direct or indirect, to cause the + direction or management of such entity, whether by contract or + otherwise, or (ii) ownership of fifty percent (50%) or more of the + outstanding shares, or (iii) beneficial ownership of such entity. + + "You" (or "Your") shall mean an individual or Legal Entity + exercising permissions granted by this License. + + "Source" form shall mean the preferred form for making modifications, + including but not limited to software source code, documentation + source, and configuration files. + + "Object" form shall mean any form resulting from mechanical + transformation or translation of a Source form, including but + not limited to compiled object code, generated documentation, + and conversions to other media types. + + "Work" shall mean the work of authorship made available under + the License, as indicated by a copyright notice that is included in + or attached to the work (an example is provided in the Appendix below). + + "Derivative Works" shall mean any work, whether in Source or Object + form, that is based on (or derived from) the Work and for which the + editorial revisions, annotations, elaborations, or other transformations + represent, as a whole, an original work of authorship. For the purposes + of this License, Derivative Works shall not include works that remain + separable from, or merely link (or bind by name) to the interfaces of, + the Work and Derivative Works thereof. + + "Contribution" shall mean, as submitted to the Licensor for inclusion + in the Work by the copyright owner or by an individual or Legal Entity + authorized to submit on behalf of the copyright owner. For the purposes + of this definition, "submitted" means any form of electronic, verbal, + or written communication sent to the Licensor or its representatives, + including but not limited to communication on electronic mailing lists, + source code control systems, and issue tracking systems that are managed + by, or on behalf of, the Licensor for the purpose of discussing and + improving the Work, but excluding communication that is conspicuously + marked or designated in writing by the copyright owner as "Not a + Contribution." + + "Contributor" shall mean Licensor and any Legal Entity on behalf of + whom a Contribution has been received by the Licensor and incorporated + within the Work. + + 2. Grant of Copyright License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + copyright license to reproduce, prepare Derivative Works of, + publicly display, publicly perform, sublicense, and distribute the + Work and such Derivative Works in Source or Object form. + + 3. Grant of Patent License. Subject to the terms and conditions of + this License, each Contributor hereby grants to You a perpetual, + worldwide, non-exclusive, no-charge, royalty-free, irrevocable + (except as stated in this section) patent license to make, have made, + use, offer to sell, sell, import, and otherwise transfer the Work, + where such license applies only to those patent claims licensable + by such Contributor that are necessarily infringed by their + Contribution(s) alone or by the combined Contribution(s) and the Work + to which such Contribution(s) was submitted. If You institute patent + litigation against any entity (including a cross-claim or counterclaim + in a lawsuit) alleging that the Work or any Contribution embodied + within the Work constitutes direct or contributory patent infringement, + then any patent licenses granted to You under this License for that + Work shall terminate as of the date such litigation is filed. + + 4. Redistribution. You may reproduce and distribute copies of the + Work or Derivative Works thereof in any medium, with or without + modifications, and in Source or Object form, provided that You + meet the following conditions: + + (a) You must give any other recipients of the Work or Derivative + Works a copy of this License; and + + (b) You must cause any modified files to carry prominent notices + stating that You changed the files; and + + (c) You must retain, in the Source form of any Derivative Works + that You distribute, all copyright, patent, trademark, and + attribution notices from the Source form of the Work, + excluding those notices that do not pertain to any part of + the Derivative Works; and + + (d) If the Work includes a "NOTICE" text file as part of its + distribution, You must include a readable copy of the + attribution notices contained within such NOTICE file, in + at least one of the following places: within a NOTICE text file + distributed as part of the Derivative Works; within the Source + form or documentation, if provided along with the Derivative + Works; or, within a display generated by the Derivative Works, + if and wherever such third-party notices normally appear. The + contents of the NOTICE file are for informational purposes only + and do not modify the License. You may add Your own attribution + notices within Derivative Works that You distribute, alongside + or as an addendum to the NOTICE text from the Work, provided + that such additional attribution notices cannot be construed + as modifying the License. + + You may add Your own license statement for Your modifications and + may provide additional grant of rights to use, copy, modify, merge, + publish, distribute, sublicense, and/or sell copies of the Work, + and to permit persons to whom the Work is furnished to do so, + subject to the following conditions: + + 5. Submission of Contributions. Unless You explicitly state otherwise, + any Contribution intentionally submitted for inclusion in the Work + by You to the Licensor shall be under the terms and conditions of + this License, without any additional terms or conditions. + Notwithstanding the above, nothing herein shall supersede or modify + the terms of any separate license agreement you may have executed + with Licensor regarding such Contributions. + + 6. Trademarks. This License does not grant permission to use the trade + names, trademarks, service marks, or product names of the Licensor, + except as required for reasonable and customary use in describing the + origin of the Work and reproducing the content of the NOTICE file. + + 7. Disclaimer of Warranty. Unless required by applicable law or + agreed to in writing, Licensor provides the Work (and each + Contributor provides its Contributions) on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or + implied, including, without limitation, any conditions of TITLE, + MERCHANTIBILITY, or FITNESS FOR A PARTICULAR PURPOSE. + See the License for the specific language governing permissions and + limitations under the License. + + 8. Limitation of Liability. In no event and under no legal theory, + whether in tort (including negligence), contract, or otherwise, + unless required by applicable law (such as deliberate and grossly + negligent acts) or agreed to in writing, shall any Contributor be + liable to You for damages, including any direct, indirect, special, + incidental, or exemplary damages of any character arising as a + result of this License or out of the use or inability to use the + Work (even if such Contributor has been advised of the possibility + of such damages). + + 9. Accepting Warranty or Additional Liability. While redistributing + the Work or Derivative Works thereof, You may choose to offer, + and charge a fee for, acceptance of support, warranty, indemnity, + or other liability obligations and/or rights consistent with this + License. However, in accepting such obligations, You may offer only + conditions consistent with this License, subject to the following + additional conditions: + + (a) You may offer additional warranty, indemnity, or other liability + terms and conditions; and + + (b) You may offer support for the Work in return for a fee. + + END OF TERMS AND CONDITIONS + + APPENDIX: How to apply the Apache License to your work. + + To apply the Apache License to your work, attach the following + boilerplate notice, with the fields enclosed by brackets "[]" + replaced with your own identifying information. (Don't include + the brackets!) The text should be enclosed in the appropriate + comment syntax for the file format in question. It may also be + possible to make it available with a creative commons license. + + Copyright 2026 Christian Manivong + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. diff --git a/README.md b/README.md index 2a7c61b..a3a690d 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -# napalm-netgear +# napalm-netgear-switches NAPALM community driver for **Netgear Smart Managed** and **Netgear Plus Managed** switches (GS108EPP, GS110TP, GS316EPP and compatible Smart Managed Pro series). @@ -18,20 +18,24 @@ NAPALM community driver for **Netgear Smart Managed** and **Netgear Plus Managed | Dependency | Minimum version | |---|---| -| Python | 3.8 | +| Python | 3.10 | | NAPALM | 4.0 | +| napalm-device-types | 4.21.1 | | Netmiko | 4.0 | ## Installation ```bash -pip install napalm-netgear +pip install napalm-netgear-switches ``` +The name `napalm-netgear` on PyPI belongs to another project. The import package is +still `napalm_netgear`, and the drivers are still `netgear_smart` and `netgear_plus`. + Or from source: ```bash -git clone https://github.com/napalm-automation-community/napalm-netgear +git clone https://git.netork.io/NAPALM/napalm-netgear.git cd napalm-netgear pip install -e . ``` @@ -102,9 +106,11 @@ Any additional keyword arguments are forwarded to Netmiko. ## Development +The rules are in [STANDARDS.md](https://git.netork.io/NAPALM/driver-standard/src/branch/main/STANDARDS.md). + ```bash -pip install -e ".[dev]" -pytest tests/ +python -m venv .venv && .venv/bin/pip install -e ".[dev]" +.venv/bin/pytest --cov ``` ## License diff --git a/napalm_netgear/py.typed b/napalm_netgear/py.typed new file mode 100644 index 0000000..e69de29 diff --git a/pyproject.toml b/pyproject.toml index 9aee7b2..0b10bc4 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -1,32 +1,31 @@ [build-system] -requires = ["setuptools>=64", "wheel"] +requires = ["setuptools>=77"] build-backend = "setuptools.build_meta" [project] -name = "napalm-netgear" +# "napalm-netgear" on PyPI belongs to someone else (STANDARDS.md §8). +name = "napalm-netgear-switches" version = "0.5.0" description = "NAPALM driver for Netgear switches (Plus/Smart)" readme = "README.md" -license = { text = "Apache-2.0" } -requires-python = ">=3.8" +license = "Apache-2.0" +requires-python = ">=3.10" authors = [ { name = "Christian Manivong" }, ] classifiers = [ "Topic :: Utilities", - "License :: OSI Approved :: Apache Software License", "Programming Language :: Python :: 3", - "Programming Language :: Python :: 3.8", - "Programming Language :: Python :: 3.9", "Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.12", + "Programming Language :: Python :: 3.13", "Operating System :: POSIX :: Linux", "Operating System :: MacOS", ] dependencies = [ "napalm>=4.0.0", - "napalm-device-types>=4.19.0", + "napalm-device-types>=4.21.1", "netmiko>=4.0.0", "paramiko>=5.0.0", # CVE-2026-44405 "netaddr", @@ -34,24 +33,28 @@ dependencies = [ ] [project.optional-dependencies] -dev = [ - "pytest", - "pytest-cov", - "black", - "ruff", -] +dev = ["pytest>=8", "pytest-cov>=5", "mypy>=1.11", "ruff>=0.6"] [project.entry-points."napalm.drivers"] netgear_smart = "napalm_netgear:NetgearSmartDriver" netgear_plus = "napalm_netgear:NetgearPlusDriver" [project.urls] -Repository = "https://github.com/napalm-automation-community/napalm-netgear" +Repository = "https://git.netork.io/NAPALM/napalm-netgear" +Issues = "https://git.netork.io/NAPALM/napalm-netgear/issues" +Changelog = "https://git.netork.io/NAPALM/napalm-netgear/src/branch/main/CHANGELOG.md" + +[tool.napalm-standard] +# The distribution name differs from the import package. +package = "napalm_netgear" [tool.setuptools.packages.find] where = ["."] include = ["napalm_netgear*"] +[tool.setuptools.package-data] +napalm_netgear = ["py.typed"] + [tool.ruff] line-length = 100 target-version = "py310" @@ -62,3 +65,27 @@ select = ["E", "F", "I", "UP", "B"] [tool.ruff.lint.per-file-ignores] # Recorded device output keeps its lines. "tests/**" = ["E501"] + +[tool.mypy] +python_version = "3.10" +strict = true +# napalm itself is untyped, so every driver subclasses Any. +disallow_subclassing_any = false + +[[tool.mypy.overrides]] +module = ["napalm.*", "netaddr.*", "py_netgear_plus.*"] +ignore_missing_imports = true + +[[tool.mypy.overrides]] +# Not yet under strict mypy (quality baseline); may only shrink. +module = ["napalm_netgear.netgear_plus", "napalm_netgear.netgear_smart"] +ignore_errors = true + +[tool.pytest.ini_options] +testpaths = ["tests"] + +[tool.coverage.run] +source = ["napalm_netgear"] + +[tool.coverage.report] +fail_under = 48 diff --git a/tests/quality_baseline.json b/tests/quality_baseline.json new file mode 100644 index 0000000..0d88aa9 --- /dev/null +++ b/tests/quality_baseline.json @@ -0,0 +1,40 @@ +{ + "coverage_floor": 48.0, + "function_complexity": { + "napalm_netgear/netgear_plus.py::NetgearPlusDriver.get_vlans_detail": 14, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._add_lag_info_v7": 13, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._get_lldp_table": 12, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._get_lldp_table_v7": 11, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._get_vlans_v7": 11, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._parse_interfaces": 19, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._parse_lldp_detail": 21, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_interfaces_counters": 12, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_poe_status": 11, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_route_to": 12, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_snmp_config": 16, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_snmp_information": 11 + }, + "function_lines": { + "napalm_netgear/netgear_plus.py::NetgearPlusDriver.get_vlans_detail": 67, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver._parse_interfaces": 78, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_arp_table": 52, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_facts": 64, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_interfaces_counters": 75, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_interfaces_ip": 53, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_mac_address_table": 58, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_poe_status": 53, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_route_to": 57, + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.ping": 56 + }, + "mypy_relaxed": [ + "napalm_netgear.netgear_plus", + "napalm_netgear.netgear_smart" + ], + "python_file_lines": { + "napalm_netgear/netgear_smart.py": 2070 + }, + "untyped_public": [ + "napalm_netgear/netgear_plus.py::NetgearPlusDriver.get_snmp_config", + "napalm_netgear/netgear_smart.py::NetgearSmartDriver.get_snmp_config" + ] +}