Names on the device carry netOrk's name, which netOrk's ARCHITECTURE rules out #49

Open
opened 2026-10-30 20:43:34 +00:00 by christianmanivong · 0 comments
Owner

netOrk's docs/ARCHITECTURE.md:3326 says: "Names on the device carry the driver's name or none, never netOrk's: temporary files, …". This repo uses netOrk's name in napalm_linux/linux.py:

  • line 168: _STAGE_TEMPLATE = "/tmp/netork-stage.XXXXXX";
  • .netork-tmp in _install_file_as_root;
  • line 87: _RC_MARKER = "__NETORK_RC=" (shell output, not a file; may or may not count as a name on the device).

Same pattern in napalm-device-types (ssh_server.py), filed there.

Two directions (decision per NetOrk docs-vs-code rule):

  • Code follows the doc: rename to the driver's name (e.g. napalm-…). A renamed drop-in needs the old file removed on the devices that already have it, or both are active.
  • Doc follows the code: ARCHITECTURE names these existing files as exceptions.

Found while building NetOrk/netork#1090 (whose new files use .napalm-bak, as the doc says).

Prio: P4 — a naming rule; nothing behaves wrong.

netOrk's `docs/ARCHITECTURE.md:3326` says: "**Names on the device** carry the driver's name or none, never netOrk's: temporary files, …". This repo uses netOrk's name in `napalm_linux/linux.py`: - line 168: `_STAGE_TEMPLATE = "/tmp/netork-stage.XXXXXX"`; - `.netork-tmp` in `_install_file_as_root`; - line 87: `_RC_MARKER = "__NETORK_RC="` (shell output, not a file; may or may not count as a name on the device). Same pattern in napalm-device-types (`ssh_server.py`), filed there. **Two directions (decision per NetOrk docs-vs-code rule):** - **Code follows the doc:** rename to the driver's name (e.g. `napalm-…`). A renamed drop-in needs the old file removed on the devices that already have it, or both are active. - **Doc follows the code:** ARCHITECTURE names these existing files as exceptions. Found while building NetOrk/netork#1090 (whose new files use `.napalm-bak`, as the doc says). Prio: P4 — a naming rule; nothing behaves wrong.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: NAPALM/napalm-linux#49