linux.py uses Dict, List and Optional without importing them #29

New Issue

2026-10-14T08:22:58Z

christianmanivong commented

2026-10-14 08:22:58 +00:00

ruff check --select F821 napalm_linux/linux.py reports 30 undefined names: 12 × Dict, 16 × List, 2 × Optional. It only works because of from __future__ import annotations; typing.get_type_hints(LinuxDriver.get_route_to) raises NameError.

Fix: import them, or use the builtins. Add F821 to the lint run.

Part of NetOrk/netork#1105. Plan: NAPALM/napalm-device-types docs/STRUCTURE.md (branch docs/structure-plan).

Prio P4: no runtime failure today.

`ruff check --select F821 napalm_linux/linux.py` reports 30 undefined names: 12 × `Dict`, 16 × `List`, 2 × `Optional`. It only works because of `from __future__ import annotations`; `typing.get_type_hints(LinuxDriver.get_route_to)` raises `NameError`. Fix: import them, or use the builtins. Add F821 to the lint run. Part of NetOrk/netork#1105. Plan: NAPALM/napalm-device-types `docs/STRUCTURE.md` (branch `docs/structure-plan`). Prio P4: no runtime failure today.

christianmanivong referenced this issue from a commit

2026-10-16 10:08:56 +00:00

fix: import the typing names the annotations use

christianmanivong referenced a pull request that will close this issue

2026-10-16 10:09:06 +00:00

feat!: fix templates with the caller's values replace run_device_action (0.8.0) #31

christianmanivong closed this issue

2026-10-16 23:17:15 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-linux#29