4 Commits

Include renames

Author	SHA1	Message	Date
Christian Manivong	38391891ec	style: ruff format and the lint rules of the driver standard ... Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff cannot fix comes in the next commit.	2026-10-22 19:09:42 +02:00
christianmanivong	350e3a6d6e	fix: adapt to napalm-device-types 4.7 ... napalm-device-types 4.7 changed three things this driver depends on: - parse_dnf_security needs the "__DNF_RC=<status>" line that DNF_SECURITY_COMMAND prints and raises ValueError without it or when dnf failed. The yum security query had no such line, so listing updates on any yum host raised. _YUM_SECURITY_COMMAND now prints the marker the same way ("{ ...; echo __DNF_RC=$?; } | cat"). _rpm_security_names checks __DNF_RC itself and turns a failed query, or output cut short before the marker, into None (security unknown) rather than "no advisories" or an exception. - OSDriver.get_users was renamed to get_os_users, since NAPALM's own get_users has another shape. LinuxDriver.get_users is now get_os_users with the same return value. - run_on_transport reads an exec channel to EOF after its exit status arrives; the tests' fake channels gain recv/recv_stderr for that. Require napalm-device-types>=4.7.1 and bump the version to 0.6.0.	2026-10-13 06:25:17 +00:00
Christian Manivong	647e058b8a	fix: refuse stdin to a privileged command while a sudo password is set ... run_command(privileged=True, stdin=data) sent `sudo -S` with stdin = <sudo password>\n + data. A sudo that does not prompt (NOPASSWD, a cached timestamp) leaves the password line on stdin, and the command reads it as the first line of the data - `cat > file` wrote it into the file (NetOrk/netork#1029). run_command now raises ValueError for that combination before opening a channel. Stdin still reaches the command under `sudo -n` (no password set), for a root login, and for unprivileged commands. Callers stage the data without privilege and have root install the file. open_stream documents the same caveat.	2026-10-12 20:41:06 +02:00
Christian Manivong	51ee33eebe	feat: run commands and streams on an exec channel, reach the container engine ... netOrk drove this driver's shell through the private `_send` (an interactive PTY, stdout and stderr merged, no exit code) and opened its own paramiko connections for Docker. napalm-device-types 2.6.0 makes the channel public; this implements it (NetOrk/netork#765): - `run_command()` and `open_stream()` open an exec channel on the SSH transport netmiko already holds: no second login, no PTY, a real exit status. - `privileged=True` follows the driver's existing rules: as root the command runs directly; with a sudo password it goes through `sudo -S -p ''` and the password is written to stdin, never onto the command line; without one `sudo -n` fails at once instead of hanging. - `ContainerEngineMixin` is mixed in, so `open_container_engine("docker")` streams the Engine API over `docker system dial-stdio`. The existing Docker methods are unchanged. Version 0.2.0, requires napalm-device-types >= 2.6.0. Refs NAPALM/napalm-device-types#17	2026-10-07 17:59:32 +02:00