fix(driver): load_replace_candidate is None, not a stub that raises (NetOrk/netork#2503)
driver / lint (pull_request) Successful in 19s
driver / standard (pull_request) Failing after 27s
driver / types (pull_request) Successful in 3m34s
driver / test (3.13) (pull_request) Successful in 3m12s
driver / test (3.12) (pull_request) Successful in 3m23s
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Failing after 4m54s
driver / publish (pull_request) Skipped
driver / lint (pull_request) Successful in 19s
driver / standard (pull_request) Failing after 27s
driver / types (pull_request) Successful in 3m34s
driver / test (3.13) (pull_request) Successful in 3m12s
driver / test (3.12) (pull_request) Successful in 3m23s
driver / lowest (pull_request) Successful in 35s
driver / build (pull_request) Successful in 35s
driver / security (pull_request) Successful in 1m15s
CI / driver (pull_request) Failing after 4m54s
driver / publish (pull_request) Skipped
The driver cannot replace a device's configuration, and said so with a load_replace_candidate that raised NotImplementedError. A method that only raises still looks like a replace to anyone who asks whether the driver has one: netOrk offered a config restore for these devices that could only fail. None is how a driver switches off a method, the convention netOrk's capability checks and napalm-device-types follow, so asking now says no. Nothing in the driver calls it.
This commit is contained in:
1 parent
5f6595d160
commit
c9a9d532aa
4 files changed
+25
-3
No files matched your search
@@ -0,0 +1,17 @@
|
||||
"""The driver cannot replace a device's configuration, and says so by not having the method.
|
||||
|
||||
A ``load_replace_candidate`` that only raises looks like a replace to anyone who asks
|
||||
whether the driver has one: netOrk offered a config restore for these devices that
|
||||
could only fail (NetOrk/netork#2503). ``None`` is how a driver switches off a method
|
||||
it would otherwise inherit, the convention of napalm-device-types and netOrk's
|
||||
capability checks.
|
||||
"""
|
||||
|
||||
from __future__ import annotations
|
||||
|
||||
from napalm_linux import LinuxDriver
|
||||
|
||||
|
||||
def test_the_driver_has_no_config_replace():
|
||||
assert LinuxDriver.load_replace_candidate is None
|
||||
assert not callable(getattr(LinuxDriver, "load_replace_candidate", None))
|
||||
Reference in new issue
Block a user