chore: adopt the NAPALM driver standard #7

Merged

christianmanivong merged 4 commits from chore/driver-standard into main 2026-10-23 12:53:46 +00:00

Conversation 0 Commits 4 Files Changed 10

+376 -106

christianmanivong commented 2026-10-23 07:04:00 +00:00

Owner

Copy link

Copy source

Summary

napalm-fritzbox adopts the NAPALM driver standard (https://git.netork.io/NAPALM/driver-standard).
Epic: NAPALM/driver-standard#2.

Changes

• style: ruff format and ruff check --fix with the standard's rule set (E, F, I, UP, B, line length 100, Python 3.10). Mechanical.
• fix: bandit is clean: the catch-all except Exception: continue in get_wan_status logs at debug level before the next WAN service is tried (B112); the "any remote host" placeholder of get_nat_translations is a named constant with a nosec (B104, reported data, never a bind). No behaviour change.
• chore: CI in .gitea/ calling the shared workflow, .github/ removed; napalm-device-types >=4.21.1 from PyPI; LICENSE, CHANGELOG, py.typed, SPDX license, setuptools>=77, dev extra floors, URLs on git.netork.io (README included); strict mypy with napalm_fritzbox.fritzbox exempt; coverage floor 81 %; quality baseline.

Related Issue

Closes #6

Testing

Locally: 70 tests, coverage 81.36 %, ruff, mypy, bandit clean; napalm-standard check and
ratchet clean; build + twine check --strict pass.

## Summary napalm-fritzbox adopts the NAPALM driver standard (https://git.netork.io/NAPALM/driver-standard). Epic: NAPALM/driver-standard#2. ## Changes - **style**: ruff format and ruff check --fix with the standard's rule set (E, F, I, UP, B, line length 100, Python 3.10). Mechanical. - **fix**: bandit is clean: the catch-all `except Exception: continue` in `get_wan_status` logs at debug level before the next WAN service is tried (B112); the "any remote host" placeholder of `get_nat_translations` is a named constant with a nosec (B104, reported data, never a bind). No behaviour change. - **chore**: CI in .gitea/ calling the shared workflow, .github/ removed; napalm-device-types >=4.21.1 from PyPI; LICENSE, CHANGELOG, py.typed, SPDX license, setuptools>=77, dev extra floors, URLs on git.netork.io (README included); strict mypy with napalm_fritzbox.fritzbox exempt; coverage floor 81 %; quality baseline. ## Related Issue Closes #6 ## Testing Locally: 70 tests, coverage 81.36 %, ruff, mypy, bandit clean; `napalm-standard check` and `ratchet` clean; build + `twine check --strict` pass.

christianmanivong added 3 commits 2026-10-23 07:04:00 +00:00

style: ruff format and the lint rules of the driver standard ... b23967417c

Mechanical: ruff format, and ruff check --fix with the rule set every NAPALM
driver uses (E, F, I, UP, B at line length 100, Python 3.10). What ruff
cannot fix comes in the next commit.

fix: what bandit and the remaining lint rules found ... a2fc59c8ab

- get_wan_status: the catch-all except Exception: continue (B112) now logs
  at debug level before the next WAN service is tried, so a swallowed
  failure leaves a trace. A module logger is new.
- The "any remote host" placeholder of get_nat_translations is a named
  constant with a nosec (B104): an address reported as data, never a
  bind. The output is unchanged.
- ruff found nothing left after the mechanical pass.

chore: adopt the NAPALM driver standard ... e352801a1a

- CI moves to .gitea/workflows/ci.yml and calls the shared driver workflow
  of NAPALM/driver-standard; .github/ is gone.
- napalm-device-types >=4.21.1 from PyPI (the floor was 0.4.0).
- LICENSE, CHANGELOG, py.typed, SPDX license string, setuptools>=77,
  version floors on the dev extra (black is gone), links to git.netork.io;
  the README names Python 3.10 and the Gitea CI.
- mypy strict for the package; napalm_fritzbox.fritzbox is exempt for now
  (6 errors), recorded in the quality baseline with four long getters.
- Coverage floor 81 % (measured 81.36 %).

christianmanivong added 1 commit 2026-10-23 09:37:05 +00:00

chore(release): 0.3.0 c5d0b0d0f6

christianmanivong merged commit efe253dc42 into main 2026-10-23 12:53:46 +00:00

christianmanivong deleted branch chore/driver-standard 2026-10-23 12:53:46 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is broken

enhancement

New feature or request

tech-debt

Refactoring / cleanup / deferred debt

prio

P0

Road blocker: blocks other work, drop everything

prio

P1

Critical

prio

P2

Important and urgent

prio

P3

Important, not urgent

prio

P4

Neither important nor urgent

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

christianmanivong

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: NAPALM/napalm-fritzbox#7