NAPALM/napalm-fritzbox
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ci: install napalm-device-types from git, so the tests run at all
CI / test (3.10) (push) Failing after 5m43s
Details
CI / test (3.11) (push) Failing after 5m39s
Details
CI / test (3.12) (push) Failing after 5m41s
Details
CI / test (3.10) (pull_request) Failing after 5m42s
Details
CI / test (3.11) (pull_request) Failing after 5m38s
Details
CI / test (3.12) (pull_request) Failing after 5m40s
Details

Browse Source 
Every CI run died at "pip install -e .[dev]": pyproject.toml asks for
napalm_device_types, which lives in git.netork.io/NAPALM rather than on PyPI,
and pip found only an unrelated 0.1.0 there. Not one test had run in CI.

The workflow now installs napalm-device-types from git first. The matrix
drops 3.8/3.9 and requires-python says >=3.10, because napalm-device-types
itself needs 3.10 -- the package never installed on anything older.

Replayed in a fresh venv: napalm-device-types 2.0.0 from git, then the
package with its dev extras, tests green.
This commit is contained in:
Christian Manivong
2026-10-04 00:43:45 +02:00
parent 13e0073659
commit e85637496c
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+4 -1
View File
@@ -12,7 +12,7 @@ jobs:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"] python-version: ["3.10", "3.11", "3.12"]
steps: steps:
- name: Checkout - name: Checkout
uses: actions/checkout@v4 uses: actions/checkout@v4
@@ -26,6 +26,9 @@ jobs:
- name: Install package with dev extras - name: Install package with dev extras
run: | run: |
python -m pip install --upgrade pip python -m pip install --upgrade pip
# napalm-device-types lives in git.netork.io/NAPALM, not on PyPI: without this
# pip looks there, finds an unrelated 0.1.0 and the job dies before any test.
python -m pip install "napalm-device-types @ git+https://git.netork.io/NAPALM/napalm-device-types.git"
python -m pip install -e ".[dev]" python -m pip install -e ".[dev]"
- name: Run unit tests - name: Run unit tests
pyproject.toml
+1 -2
View File
@@ -8,7 +8,7 @@ version = "0.1.0"
description = "NAPALM driver for AVM FritzBox (TR-064 via fritzconnection)." description = "NAPALM driver for AVM FritzBox (TR-064 via fritzconnection)."
readme = "README.md" readme = "README.md"
license = { text = "Apache-2.0" } license = { text = "Apache-2.0" }
requires-python = ">=3.9" requires-python = ">=3.10"
authors = [ authors = [
{ name = "Christian Manivong" }, { name = "Christian Manivong" },
] ]
@@ -16,7 +16,6 @@ classifiers = [
"Topic :: Utilities", "Topic :: Utilities",
"License :: OSI Approved :: Apache Software License", "License :: OSI Approved :: Apache Software License",
"Programming Language :: Python :: 3", "Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10", "Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11", "Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12", "Programming Language :: Python :: 3.12",