ci: install napalm-device-types from git, so the tests run at all
CI / test (3.10) (push) Failing after 5m43s
CI / test (3.11) (push) Failing after 5m39s
CI / test (3.12) (push) Failing after 5m41s
CI / test (3.10) (pull_request) Failing after 5m42s
CI / test (3.11) (pull_request) Failing after 5m38s
CI / test (3.12) (pull_request) Failing after 5m40s
CI / test (3.10) (push) Failing after 5m43s
CI / test (3.11) (push) Failing after 5m39s
CI / test (3.12) (push) Failing after 5m41s
CI / test (3.10) (pull_request) Failing after 5m42s
CI / test (3.11) (pull_request) Failing after 5m38s
CI / test (3.12) (pull_request) Failing after 5m40s
Every CI run died at "pip install -e .[dev]": pyproject.toml asks for napalm_device_types, which lives in git.netork.io/NAPALM rather than on PyPI, and pip found only an unrelated 0.1.0 there. Not one test had run in CI. The workflow now installs napalm-device-types from git first. The matrix drops 3.8/3.9 and requires-python says >=3.10, because napalm-device-types itself needs 3.10 -- the package never installed on anything older. Replayed in a fresh venv: napalm-device-types 2.0.0 from git, then the package with its dev extras, tests green.
This commit is contained in:
@@ -12,7 +12,7 @@ jobs:
|
||||
strategy:
|
||||
fail-fast: false
|
||||
matrix:
|
||||
python-version: ["3.9", "3.10", "3.11", "3.12"]
|
||||
python-version: ["3.10", "3.11", "3.12"]
|
||||
steps:
|
||||
- name: Checkout
|
||||
uses: actions/checkout@v4
|
||||
@@ -26,6 +26,9 @@ jobs:
|
||||
- name: Install package with dev extras
|
||||
run: |
|
||||
python -m pip install --upgrade pip
|
||||
# napalm-device-types lives in git.netork.io/NAPALM, not on PyPI: without this
|
||||
# pip looks there, finds an unrelated 0.1.0 and the job dies before any test.
|
||||
python -m pip install "napalm-device-types @ git+https://git.netork.io/NAPALM/napalm-device-types.git"
|
||||
python -m pip install -e ".[dev]"
|
||||
|
||||
- name: Run unit tests
|
||||
|
||||
Reference in New Issue
Block a user