diff --git a/tests/conftest.py b/tests/conftest.py new file mode 100644 index 0000000..1d0a710 --- /dev/null +++ b/tests/conftest.py @@ -0,0 +1,36 @@ +"""Shared test setup: unit tests never open a socket.""" + +import gc +import socket +from collections.abc import Iterator +from typing import Any + +import pytest + +_attempts: list[str] = [] + + +def _refuse_create_connection(address: Any, *args: Any, **kwargs: Any) -> socket.socket: + _attempts.append(f"create_connection{address!r}") + raise OSError("unit tests never open a socket") + + +def _refuse_connect(self: socket.socket, address: Any) -> None: + _attempts.append(f"connect{address!r}") + raise OSError("unit tests never open a socket") + + +@pytest.fixture(scope="session", autouse=True) +def _no_network() -> Iterator[None]: + """Refuse every connection and fail the run if anything tried one. + + A connection attempted from ``__del__`` (NAPALM's ``NetworkDriver.__del__`` calls + ``is_alive()`` on a driver that was never closed) is swallowed there, so the + attempts are recorded and checked once every driver has been collected. + """ + with pytest.MonkeyPatch.context() as mp: + mp.setattr(socket, "create_connection", _refuse_create_connection) + mp.setattr(socket.socket, "connect", _refuse_connect) + yield + gc.collect() + assert not _attempts, f"unit tests tried to open a socket: {_attempts}" diff --git a/tests/unit/test_driver.py b/tests/unit/test_driver.py index dca3d8f..f4b871e 100644 --- a/tests/unit/test_driver.py +++ b/tests/unit/test_driver.py @@ -268,6 +268,8 @@ def driver(): drv = FritzBoxDriver(hostname="fritz.box", username="user", password="pass") drv.fc = mock_fc yield drv + # An open driver makes NAPALM's __del__ probe fritz.box over the network (#11). + drv.close() @pytest.fixture @@ -288,6 +290,8 @@ def pppoe_driver(): drv = FritzBoxDriver(hostname="fritz.box", username="user", password="pass") drv.fc = mock_fc yield drv + # An open driver makes NAPALM's __del__ probe fritz.box over the network (#11). + drv.close() # --------------------------------------------------------------------------- @@ -309,6 +313,7 @@ class TestOpenClose: with patch("napalm_fritzbox.fritzbox.FritzConnection", return_value=mock_fc): drv.open() assert drv.fc is mock_fc + drv.close() def test_close_clears_fc(self, driver): driver.close()