From 4723c44d9de1b570d605b8fe56f5e01d5024cccb Mon Sep 17 00:00:00 2001 From: Christian Manivong Date: Mon, 20 Jul 2026 09:54:23 +0200 Subject: [PATCH] refactor(warnings): report raw signal only, align meta key naming MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit get_device_warnings() now returns only {code, meta} — severity, title, message, and action are resolved centrally by netork's WARNING_CATALOG (netork/core/device_warnings.py), not by the driver. Also renames meta.version -> meta.latest_version for firmware_update_available so it matches the netgear driver's shape and the shared catalog message template. --- napalm_fritzbox/fritzbox.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/napalm_fritzbox/fritzbox.py b/napalm_fritzbox/fritzbox.py index c5a491c..c04ba9c 100644 --- a/napalm_fritzbox/fritzbox.py +++ b/napalm_fritzbox/fritzbox.py @@ -411,9 +411,7 @@ class FritzBoxDriver(ResidentialGatewayDriver): if ui_info.get("NewX_AVM-DE_UpdateState", "") == "Available": warnings.append({ "code": "firmware_update_available", - "severity": "info", - "action": None, - "meta": {"version": ui_info.get("NewX_AVM-DE_Version", "")}, + "meta": {"latest_version": ui_info.get("NewX_AVM-DE_Version", "")}, }) except _OPTIONAL_SERVICE_ERRORS: pass @@ -424,12 +422,7 @@ class FritzBoxDriver(ResidentialGatewayDriver): # SNR margin is in dB×10; < 60 means < 6 dB — borderline line quality snr_down = int(_to_float(info.get("NewDownstreamNoiseMargin"))) if 0 < snr_down < 60: - warnings.append({ - "code": "dsl_snr_low", - "severity": "warning", - "action": None, - "meta": {"snr_db_x10": snr_down}, - }) + warnings.append({"code": "dsl_snr_low", "meta": {"snr_db_x10": snr_down}}) except _OPTIONAL_SERVICE_ERRORS: pass